Ticket #3803 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

MuonAnalysis Fitting tab: Muon specific code is in the general interface

Reported by: Martyn Gigg Owned by: Robert Whitley
Priority: major Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description

From #2974.

I'm not convinced what has been implemented is the best long-term solution as it relies on having custom code for the Muon group (and possibly others in the future) in the general interface.

A better solution may be to specialise the FitPropertyBrowser and set the appropriate differences in this class.

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Robert Whitley

Discuss the best approach with Martyn

comment:2 Changed 9 years ago by Robert Whitley

Refs #3803. Clean up the FitPropertyBrowser by removing comments.

Code taken out refers to when the FitPropertyBrowser looked at groups.

Changeset: aa41ee293e14346306afe7f627e9cd7793013e15

comment:3 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:4 Changed 9 years ago by Robert Whitley

Refs #3803. Make a new MuonFitPropertyBrowser.

Inherit from FitPropertyBrowser and be modified for muon use.

Changeset: 0f66f22b5872614e020a6dab214f22aea30ee609

comment:5 Changed 9 years ago by Robert Whitley

Refs #3803. Fix warnings.

Changeset: 575c3f264ad32a98a71c313a10bccab9e8c5f8ee

comment:6 Changed 9 years ago by Robert Whitley

  • Status changed from assigned to accepted

comment:7 Changed 9 years ago by Robert Whitley

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:8 Changed 8 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:9 Changed 8 years ago by Anders Markvardsen

  • Status changed from verifying to closed

MuonFitPropertyBrowser is now a child of FitPropertyBrowser

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4650

Note: See TracTickets for help on using tickets.