Ticket #3859 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

SliceMD algorithm: make it

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: critical Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By: #3861, #3871
Blocking: Tester: Owen Arnold

Description

Algorithm that takes a slice out of an existing MDWorkspace.

  • Define a box-style implicit function limiting the volume to look at.
    • Axis aligned only?
  • Preserves the events.
  • Preserves the dimensions and the number of dimensions.
  • Option to make the output workspace file-backed as well, if the memory used is large.

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted
  • Owner set to Janik Zikovsky

comment:2 Changed 9 years ago by Janik Zikovsky

  • Priority changed from major to critical

comment:3 Changed 9 years ago by Janik Zikovsky

  • Blocked By 3861 added

comment:4 Changed 9 years ago by Janik Zikovsky

In [14928]:

Fixes #3861: SlicingAlgorithm class will be shared by 2 algos. Refs #3859: Start of SliceMD algorithm.

comment:5 Changed 9 years ago by Janik Zikovsky

  • Blocked By 3871 added

comment:4 Changed 9 years ago by Janik Zikovsky

In [14954]:

Refs #3859: SliceMD algorithm. Lots of tests in the SlicingAlgorithmTest class to try every possibility. Better implicit function for non-axis-aligned cuts. Still not fully general, need to add non-axis-aligned 4D cuts and some reduced-dimension cuts.

comment:5 Changed 9 years ago by Janik Zikovsky

In [14982]:

Refs #3859: Generalized slices in N dimensions down to M dimensions. ImplicitFunction returns the correct shape; always for orthogonal basis vectors, and for non-orthogonal vectors in common use cases such as 2D, 3D. Extensive tests

comment:6 Changed 9 years ago by Russell Taylor

In [15019]:

Clear Intel compiler warnings. Re #3859.

comment:9 Changed 9 years ago by Janik Zikovsky

Refs #3859 file backed-output for SliceMD algo. This fixes it.

Changeset: 4098f222971962a45d6419985955c8c5723e6d47

comment:10 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

Note to testers: You have to create a MDWorkspace with events in it and take out a slice. The axis-aligned one will preserve the dimensions (though you can integrate). The non-axis-aligned one performs a coordinate transformation.

Maybe try to take out some slices and compare in Paraview?

comment:11 Changed 9 years ago by Janik Zikovsky

Refs #3859 file backed-output for SliceMD algo. This fixes it.

Changeset: 4098f222971962a45d6419985955c8c5723e6d47

comment:12 Changed 9 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:13 Changed 9 years ago by Owen Arnold

  • Status changed from verifying to closed
  • Runs without issues and with same interface as BinMD
  • Generates output MDEventWorkspace containing events
  • Performs slicing
  • Outputs in Slice viewer look correct

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4706

Note: See TracTickets for help on using tickets.