Ticket #3888 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Optimize CropWorkspace

Reported by: Vickie Lynch Owned by: Peter Peterson
Priority: major Milestone: Release 2.0
Component: Mantid Keywords:
Cc: petersonpf@… Blocked By:
Blocking: Tester: Wenduo Zhou

Description

Use OpenMP for loop and check only once for event type.

Change History

comment:1 Changed 9 years ago by Vickie Lynch

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Vickie Lynch

In [15010]:

Refs #3888 Only check EventType once for CropWorkspace

comment:3 Changed 9 years ago by Vickie Lynch

In [15011]:

Refs #3888 CropWorkspace execEvents runs in parallel

comment:4 Changed 9 years ago by Vickie Lynch

  • Status changed from accepted to verify
  • Resolution set to fixed

Pete finished this in #3890

comment:5 Changed 9 years ago by Vickie Lynch

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:6 Changed 9 years ago by Vickie Lynch

  • Status changed from reopened to accepted

comment:7 Changed 9 years ago by Vickie Lynch

Need to backout change 15010 since CropWorkspaces cannot be called twice with weighted event workspaces. Janik assures me that this change did not save much time.

comment:8 Changed 9 years ago by Vickie Lynch

In [15192]:

Refs #3888 check EventType for each EventList

comment:9 Changed 9 years ago by Vickie Lynch

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:10 Changed 9 years ago by Peter Peterson

  • Status changed from verify to reopened
  • Resolution fixed deleted

There is an issue with event processing when one of the boundaries is not specified.

comment:11 Changed 9 years ago by Peter Peterson

  • Owner changed from Vickie Lynch to Peter Peterson
  • Status changed from reopened to accepted

comment:12 Changed 9 years ago by Peter Peterson

In [15254]:

Small changes to clean up the code. Refs #3888.

comment:13 Changed 9 years ago by Peter Peterson

In [15255]:

Since the event list checks for empty already, let it take care of things. Refs #3888.

comment:14 Changed 9 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

In [15257]:

Reset the min and max x-values if they are not specified for the event case. Fixes #3888.

comment:15 Changed 9 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:16 Changed 9 years ago by Wenduo Zhou

  • Status changed from verifying to closed

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4735

Note: See TracTickets for help on using tickets.