Ticket #3889 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Remove option "vulcancorrection" in Instrument::calcConversion

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: major Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Peter, Peterson Blocked By:
Blocking: Tester: Vickie Lynch

Description

As the calibration file of VULCAN can be generated as the same definition of other powder diffractomers' calibration file, there is no more need to have the special way to calculate conversion (i.e., 1/DIFC*(1+Offset)) for Vulcan. Thus, remove the option "vulcancorrection", and correct the programs using Instrument::calcConversion()

Change History

comment:1 Changed 9 years ago by Wenduo Zhou

  • Status changed from new to verify
  • Resolution set to fixed

In [15033]:

Removed the special data handling for VULCAN in Instrument.cpp, and made the changes to the codes using this functions. Fixes #3889.

comment:2 Changed 9 years ago by Wenduo Zhou

In [15039]:

Convert revision back to 14300 from a wrong commit. Refs #3889.

comment:3 Changed 9 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:4 Changed 9 years ago by Vickie Lynch

  • Status changed from verifying to closed

Vulcan correction has been removed from AlignDetectors, etc.

comment:5 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4736

Note: See TracTickets for help on using tickets.