Ticket #3964 (closed: duplicate)

Opened 9 years ago

Last modified 5 years ago

SANS: improve code in isis_reduction_step which loads data

Reported by: Anders Markvardsen Owned by: Gesner Passos
Priority: minor Milestone: Release 3.2
Component: SANS Keywords:
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description (last modified by Anders Markvardsen) (diff)

Currently this code looks like:

if os.path.splitext(self._data_file)[1].lower().startswith('.r'):

try:

alg = LoadRaw(self._data_file, workspace, SpectrumMin=self._spec_min, SpectrumMax=self._spec_max)

except ValueError:

# MG - 2011-02-24: Temporary fix to load .sav or .s* files. Lets the file property # work it out file_hint = os.path.splitext(self._data_file)[0] alg = LoadRaw(file_hint, workspace, SpectrumMin=self._spec_min, SpectrumMax=self._spec_max) self._data_file = alg.getPropertyValue("Filename")

LoadSampleDetailsFromRaw(workspace, self._data_file)

workspace = self._leaveSinglePeriod(workspace, period)

else:

alg = LoadNexus(self._data_file, workspace,

SpectrumMin=self._spec_min, SpectrumMax=self._spec_max, EntryNumber=period)

self._data_file = alg.getPropertyValue("Filename")

Use here instead the newer generic Load() algorithm

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:2 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:3 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

http://www.mantidproject.org/Release_Notes_2_2_Full_List

comment:4 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:5 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:6 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:7 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:8 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to the Backlog after the code freeze for R2.6

comment:9 Changed 7 years ago by Anders Markvardsen

  • Owner changed from Anders Markvardsen to Gesner Passos
  • Description modified (diff)

comment:10 Changed 7 years ago by Gesner Passos

  • Component changed from Framework to SANS

comment:11 Changed 7 years ago by Gesner Passos

  • Status changed from new to verify
  • Resolution set to duplicate

What was done in #8505 covers this ticket as well.

comment:12 Changed 7 years ago by Gesner Passos

  • Milestone changed from Backlog to Release 3.2

comment:13 Changed 7 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:14 Changed 7 years ago by Anders Markvardsen

  • Status changed from verifying to closed

This has been implemented use of generic Load

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4811

Note: See TracTickets for help on using tickets.