Ticket #4025 (closed: fixed)
SmoothNeighbours: generalize the algorithm
Reported by: | Janik Zikovsky | Owned by: | Janik Zikovsky |
---|---|---|---|
Priority: | critical | Milestone: | Release 2.0 |
Component: | Mantid | Keywords: | |
Cc: | owen.arnold@… | Blocked By: | |
Blocking: | Tester: | Owen Arnold |
Description
11:22:15 AM EDT] * Owen Arnold invited janikzikovsky [11:24:18 AM EDT] Owen Arnold: Janik, we need a generic SumNeighbours algorithm. It's quite high priority at this end. Did you write the original one? [11:24:45 AM EDT] Janik Zikovsky: Yes I did [11:25:31 AM EDT] Janik Zikovsky: What are the requirements? [11:26:28 AM EDT] Owen Arnold: Pascal wants to be able to find nearest neighbours within a radius and then plot summed counts against tof. [11:27:24 AM EDT] Owen Arnold: I think he'd be quite flexible on how the radius is specified. (like the current algorithm). [11:27:39 AM EDT] Janik Zikovsky: EventWorkspace and/or Workspace2D? [11:27:45 AM EDT] Owen Arnold: Workspace2D [11:28:16 AM EDT] Owen Arnold: I think the algorithm already works EventWorkspace, I guess SumNeighbours should do both? [11:28:41 AM EDT] Janik Zikovsky: It doesn't handle Workspace2D now; it should though [11:28:54 AM EDT] Owen Arnold: According to the wiki it doesn't [11:29:10 AM EDT] Janik Zikovsky: I'm assuming that he wants a moving average, i.e. same # of spectra in the output as in the input? [11:29:54 AM EDT] Owen Arnold: Yes [11:30:32 AM EDT] Janik Zikovsky: OK will do
Change History
comment:2 Changed 9 years ago by Janik Zikovsky
- Summary changed from SumNeighbours: generalize the algorithm to SmoothNeighbours: generalize the algorithm
comment:3 Changed 9 years ago by Janik Zikovsky
Refs #4025 starting smoothNeighbors
Changeset: cedd5b15679dc64399bff21dd2d8ca540fb97f7f
comment:4 Changed 9 years ago by Janik Zikovsky
Refs #4025 SmoothNeighbours much more general. Much faster method for finding neighbours added on MatrixWorkspace
Changeset: ba12917b6be2d07b9665abbb3ad86f4341e7900d
comment:5 Changed 9 years ago by Janik Zikovsky
Refs #4025 wiki
Changeset: 71c7b5e71c446e5af1c34da2bb1340d86acc36bd
comment:6 Changed 9 years ago by Janik Zikovsky
- Status changed from accepted to verify
- Resolution set to fixed
comment:7 Changed 9 years ago by Janik Zikovsky
Refs #4025 fix for windows that really needs to update their openMP
Changeset: c7373722d7429aaf268b707cf4e2f67a61b8ee6f
comment:8 Changed 9 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:9 Changed 9 years ago by Owen Arnold
- Status changed from verifying to closed
I've been using this algorithm heavily over the last iteration and it definitely does work on instruments with non-rectangular detectors and take input workspace of type Matrix as well as Event.
comment:10 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 4872