Ticket #4061 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Base class for Binary/Unary operations on MDWorkspaces

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: #4036 Tester: Michael Reuter

Description

Similar to the MatrixWorkspace case, create BinaryOperationMD and UnaryOperationMD classes

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Janik Zikovsky

Will move PlusMD to MDAlgorithms

comment:3 Changed 9 years ago by Janik Zikovsky

Refs #4061 : a BinaryOperation base class

With a full suite of tests for compatibility. Future algorithms like MultiplyMD should be trivial to implement (at least in the MDHIsto case

Changeset: 055c79c8bfd35b6841e029aea58d941bc192cc89

comment:4 Changed 9 years ago by Janik Zikovsky

Refs #4061 : a BinaryOperation base class

With a full suite of tests for compatibility. Future algorithms like MultiplyMD should be trivial to implement (at least in the MDHIsto case

Changeset: 055c79c8bfd35b6841e029aea58d941bc192cc89

comment:5 Changed 9 years ago by Janik Zikovsky

Refs #4061: Unary operation base class for MDWS.

Changeset: 5b7492a52788083c4f78b1ea7b7fb8d9086a47ae

comment:6 Changed 9 years ago by Janik Zikovsky

Refs #4061 added a checkInputs

This fixes it.

Changeset: 26f7f1e2bbc01d58702615934d05bc9c9974605b

comment:7 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:8 Changed 9 years ago by Janik Zikovsky

Refs #4061: Unary operation base class for MDWS.

Changeset: 5b7492a52788083c4f78b1ea7b7fb8d9086a47ae

comment:9 Changed 9 years ago by Janik Zikovsky

Refs #4061 added a checkInputs

This fixes it.

Changeset: 26f7f1e2bbc01d58702615934d05bc9c9974605b

comment:10 Changed 9 years ago by Michael Reuter

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:11 Changed 9 years ago by Janik Zikovsky

  • Status changed from reopened to accepted 
LoadMD(Filename='TOPAZ_3680_5_sec_MDEW.nxs', OutputWorkspace='TOPAZ_3680')
BinMD(InputWorkspace='TOPAZ_3680',AlignedDimX='Q_lab_z,2,12,50',
AlignedDimY='Q_lab_x,-10,10,100',OutputWorkspace='TOPAZ_3680_2D')
PlusMD(LHSWorkspace='TOPAZ_3680_2D', RHSWorkspace='TOPAZ_3680_2D', OutputWorkspace='TOPAZ_3680_2D_Plus')

should work.

comment:12 Changed 9 years ago by Janik Zikovsky

Refs #4061: one-char typo fix to CloneMDWorkspace

that fixes PlusMD B = A+A. Added missing test for this scenario.

Changeset: 32b01b28156964242398d59e3354381b25363ee2

Last edited 9 years ago by Janik Zikovsky (previous) (diff)

comment:13 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:14 Changed 9 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:15 Changed 9 years ago by Michael Reuter

  • Status changed from verifying to closed

I've tested most of the operations and everything matches expectations.

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4908

Note: See TracTickets for help on using tickets.