Ticket #4036 (closed: fixed)
Implement all binary and unary operations for the MDHistoWorkspace
| Reported by: | Janik Zikovsky | Owned by: | Janik Zikovsky |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.0 |
| Component: | Mantid | Keywords: | |
| Cc: | 3y9@… | Blocked By: | #4052, #4061 |
| Blocking: | Tester: | Owen Arnold |
Description
| , etc. |
Change History
comment:3 Changed 9 years ago by Janik Zikovsky
Refs #4036 all standard binary operations and boolean ops on MDHistoWorkspace
Changeset: c36e8f7ab994a741630057833d6e5afd7a9a1dd9
comment:5 Changed 9 years ago by Janik Zikovsky
Note: Need to add MinusMD, MultiplyMD, DivideMD etc. algorithms to cover these cases.
comment:7 Changed 9 years ago by Janik Zikovsky
Refs #4036 binary ops mdhw
Changeset: ee66d6cec05aaf7f6d6e9909b9774ea6d2e17181
comment:8 Changed 9 years ago by Janik Zikovsky
Refs #4036 all standard binary operations and boolean ops on MDHistoWorkspace
Changeset: c36e8f7ab994a741630057833d6e5afd7a9a1dd9
comment:9 Changed 9 years ago by Janik Zikovsky
Refs #4036 a few more methods on MDHistoWorkspace
renamed some others.
Changeset: 9db3b9f96cc04de87b36d484a3b70b4b167c9bad
comment:10 Changed 9 years ago by Janik Zikovsky
Refs #4036: All binary operations MD
No MDEvent - MDEvent operation for now, will add if needed.
Changeset: 678ddee320d585ddc6fecc1042b2b2709d12862b
comment:11 Changed 9 years ago by Janik Zikovsky
comment:12 Changed 9 years ago by Russell Taylor
Fix windows linker error. Re #4036.
Changeset: 0196e2d10f4a86fce3cffc9acef4a2fb35d8d221
comment:13 Changed 9 years ago by Russell Taylor
Don't know why this worked for me without this... Re #4036.
Changeset: fda755a1384405dd915be71f891066acbc95f120
comment:14 Changed 9 years ago by Janik Zikovsky
Refs #4036 unary op test helper
Changeset: 1899fe1452e46e9414f43d7a7bed9e69020adf6a
comment:15 Changed 9 years ago by Janik Zikovsky
Refs #4036 unary op test helper
Changeset: c964933fc9b459c3a14767bbea5020967491947b
comment:16 Changed 9 years ago by Janik Zikovsky
Refs #4036 several boolean ops on MDHisto
Changeset: 213658e3447fa2d74904cf561edf1a9d74a65510
comment:17 Changed 9 years ago by Janik Zikovsky
Refs #4036 3 unary operations on MDHisto
Changeset: 9ee9c6bddf11c02ed612f6ce7b14601c9f4eaa87
comment:18 Changed 9 years ago by Janik Zikovsky
Refs #4036 More tests and the NotMD algo.
Changeset: dd9b7dee7f55f9ac16fdd1303c900334895e0ce2
comment:19 Changed 9 years ago by Janik Zikovsky
Refs #4036 updating wiki docs
Changeset: 61fc1012021a008bf3fa6a99d35e529f39a8d668
comment:20 Changed 9 years ago by Janik Zikovsky
Refs #4036 a few more methods on MDHistoWorkspace
renamed some others.
Changeset: 9db3b9f96cc04de87b36d484a3b70b4b167c9bad
comment:21 Changed 9 years ago by Janik Zikovsky
Refs #4036: All binary operations MD
No MDEvent - MDEvent operation for now, will add if needed.
Changeset: 678ddee320d585ddc6fecc1042b2b2709d12862b
comment:22 Changed 9 years ago by Janik Zikovsky
comment:23 Changed 9 years ago by Russell Taylor
Fix windows linker error. Re #4036.
Changeset: 0196e2d10f4a86fce3cffc9acef4a2fb35d8d221
comment:24 Changed 9 years ago by Russell Taylor
Don't know why this worked for me without this... Re #4036.
Changeset: fda755a1384405dd915be71f891066acbc95f120
comment:25 Changed 9 years ago by Janik Zikovsky
Refs #4036 unary op test helper
Changeset: 1899fe1452e46e9414f43d7a7bed9e69020adf6a
comment:26 Changed 9 years ago by Janik Zikovsky
Refs #4036 unary op test helper
Changeset: c964933fc9b459c3a14767bbea5020967491947b
comment:27 Changed 9 years ago by Janik Zikovsky
Refs #4036 several boolean ops on MDHisto
Changeset: 213658e3447fa2d74904cf561edf1a9d74a65510
comment:28 Changed 9 years ago by Janik Zikovsky
Refs #4036 3 unary operations on MDHisto
Changeset: 9ee9c6bddf11c02ed612f6ce7b14601c9f4eaa87
comment:29 Changed 9 years ago by Janik Zikovsky
Refs #4036: added 7 algorithms
Changeset: 026651bc0773152e5208297f34c02d900ff9a980
comment:30 Changed 9 years ago by Janik Zikovsky
Refs #4036 tests for 6 algos
in the boolean-type operation style
Changeset: 28e4c2dac55d2cac5d694029d632d6aefe518aec
comment:31 Changed 9 years ago by Janik Zikovsky
Refs #4036 More tests and the NotMD algo.
Changeset: dd9b7dee7f55f9ac16fdd1303c900334895e0ce2
comment:32 Changed 9 years ago by Janik Zikovsky
Refs #4036 updating wiki docs
Changeset: 61fc1012021a008bf3fa6a99d35e529f39a8d668
comment:33 Changed 9 years ago by Janik Zikovsky
- Status changed from accepted to verify
- Resolution set to fixed
OK all the algorithms are created. #4083 continues this for exposing it to python. There's also #4081 which is a related algorithm.
Note for testers: here is the list of algorithms that were created as part of this ticket: PlusMD MinusMD DivideMD MultiplyMD ExponentialMD PowerMD LogarithmMD NotMD AndMD OrMD XorMD LessThanMD GreaterThanMD EqualToMD.
The more detailed testing is done in the MDHistoWorkspaceTest, and then lots of unit testing in BinaryOperationMDTest. Each algo also has its tests.
Have fun!
comment:34 Changed 9 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:35 Changed 9 years ago by Owen Arnold
- Status changed from verifying to closed
Great design. Algorithms forward to named methods on MDHistoWorkspace. Very high level of test coverage. Inspected and then executed all unit tests covering this functionality.
comment:36 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 4883
They should all be exposed to python as well.