Ticket #4075 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

NearestNeighbours With ManagedWorkspaces

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: critical Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description

NearestNeighbours is NotFoundException during ::defaultNeighbours() method for managed workspaces. This is not happening for pure in-memory workspaces.

To reproduce. *Generate a managed workspace *Run smooth neighbours algorithm on that workspace *Fails to find spectrum index 1 and throws

Attachments

ticket4075_checkworkspacesmatch.txt (156.0 KB) - added by Stuart Campbell 9 years ago.

Change History

comment:1 Changed 9 years ago by Owen Arnold

  • Status changed from new to accepted
  • Owner changed from Anyone to Owen Arnold

comment:2 Changed 9 years ago by Owen Arnold

Fixed as part of #4080.

For the tester: As expected, the smoothneighbours algorithm takes a long time to run on a managed workspace. To test this ticket, try the following:

  • Load a wish file. These can be found in the data directory of mantid in raw format.
  • Keep repeating the first step until you have a managed workspace, or reduce the user properties file memory threshold to 1. Remember to unset your changes to property files after testing!
  • Once you have a managed workspace open run the smoothneighbours algorithm with numberofneighbours = 35, provideradius=false, weights=false. This is going to take a long time, over 3hours on my machine, so best to run it overnight.
  • you might like to compare the results of running this algorithm on a unmanaged workspace using checkworkspacesmatch. Ignore differences in the number of logs.

comment:3 Changed 9 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 9 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:5 Changed 9 years ago by Stuart Campbell

Used raw file WISH00016748.raw, loaded as both a managed and unmanaged workspace. Then ran SmoothNeighbours with RadiusUnits=NumberOfPixels, Radius=3, NumberOfNeighbours=35, WeightedSum=35.

Changed 9 years ago by Stuart Campbell

comment:6 Changed 9 years ago by Owen Arnold

refs #4075. Disable managed workspaces. See #4471

Changeset: 1d70848daea66e6dbabdc03133334276dc9592ec

comment:7 Changed 9 years ago by Stuart Campbell

  • Status changed from verifying to closed

If you try to run now with a Managed Workspace you get

SmoothNeighbours started
Error in execution of algorithm SmoothNeighbours:
SmoothNeighbours algorithm cannot be used with Managed Workspaces

which is the correct behaviour.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4922

Note: See TracTickets for help on using tickets.