Ticket #4080 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Smooth neighbours ignore monitors

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: critical Milestone: Release 2.0
Component: VATES Keywords:
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description

Smooth nearest neighbours is looping through monitors and unable to find them in the spectrum detector map.

To reproduce the issue.

  • Load a wish workspace (set spectrum range to be non-default). i.e. min=1, max=1000
  • Run SmoothNeighbours on the workspace with NumberOfNeighbours=8,Weights=False,ProvideRadius=False
  • Throws an exeception while trying to find spectrum number = 1

Change History

comment:1 Changed 9 years ago by Owen Arnold

  • type changed from enhancement to defect

comment:2 Changed 9 years ago by Owen Arnold

  • Status changed from new to accepted

comment:3 Changed 9 years ago by Owen Arnold

Martyn and I find that we can identify whether a detector is a monitor and ignore (continue over) it when we perform the smoothneighbours.

comment:4 Changed 9 years ago by Owen Arnold

refs #4080. Apply the fix

Changeset: 6a63de04b78f5a9818f2e7a6e8eae1ba484b808f

comment:5 Changed 9 years ago by Owen Arnold

refs #4080. Apply the fix

Changeset: 6a63de04b78f5a9818f2e7a6e8eae1ba484b808f

comment:6 Changed 9 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester: Verify that monitors are not considered in the smooth neighbours algorithm. See Owen Arnold for more info if needed.

comment:7 Changed 9 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:8 Changed 9 years ago by Nick Draper

  • Status changed from verifying to closed

tested with WISH 17986 once we figured out we needed to provide a value for the radius

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4927

Note: See TracTickets for help on using tickets.