Ticket #4173 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Fix sort for Peaks Table

Reported by: Vickie Lynch Owned by: Janik Zikovsky
Priority: major Milestone: Release 2.0
Component: Mantid Keywords:
Cc: petersonpf@… Blocked By:
Blocking: Tester: Wenduo Zhou

Description

Peaks workspace should be able to sort all rows based on a single column

Change History

comment:1 Changed 9 years ago by Vickie Lynch

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Vickie Lynch

Refs #4173 Fix type for sorting all columns

Changeset: f98d40d6fc46e5f05502f765feff8a6b10bc56e8

comment:3 Changed 9 years ago by Vickie Lynch

Refs #4173 No columns are readonly now which prevents sorting

Changeset: c883b485d7f881391c0a9f31a727bb187eb7ee23

comment:4 Changed 9 years ago by Vickie Lynch

  • Status changed from accepted to verify
  • Resolution set to fixed

Peaks workspace should be able to sort all rows based on a single column

comment:5 Changed 9 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:6 Changed 9 years ago by Janik Zikovsky

  • Status changed from verifying to reopened
  • Resolution fixed deleted

The table sorts in the view but the underlying list of peaks is not resorted. This causes issues later, e.g. if you modify a value in the table it will modify the "wrong" peak.

comment:7 Changed 9 years ago by Janik Zikovsky

  • Status changed from reopened to accepted
  • Owner changed from Vickie Lynch to Janik Zikovsky

comment:8 Changed 9 years ago by Janik Zikovsky

Refs #4173: restored read-only-ness of some peak columns

also indentation fix to SortDialog

Changeset: 45acb3505292d33183331211164877245c12b2cc

comment:9 Changed 9 years ago by Janik Zikovsky

Refs #4173: Sort on a PeaksWorkspace table view sorts underlying peaks

but other tables will use the default sorting methods. Sorting columns independently of each other (which does not make sense when sorting peaks) will not work, instead all columns are sorted together

Changeset: 8142f2fcf173a1c6634f167fb356b438c60a1f8b

comment:10 Changed 9 years ago by Janik Zikovsky

Refs #4173: restored read-only-ness of some peak columns

also indentation fix to SortDialog

Changeset: 45acb3505292d33183331211164877245c12b2cc

comment:11 Changed 9 years ago by Janik Zikovsky

Refs #4173: Sort on a PeaksWorkspace table view sorts underlying peaks

but other tables will use the default sorting methods. Sorting columns independently of each other (which does not make sense when sorting peaks) will not work, instead all columns are sorted together

Changeset: 8142f2fcf173a1c6634f167fb356b438c60a1f8b

comment:12 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:13 Changed 9 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester changed from Janik Zikovsky to Wenduo Zhou

comment:14 Changed 9 years ago by Wenduo Zhou

  • Status changed from verifying to closed

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5020

Note: See TracTickets for help on using tickets.