Ticket #4249 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Find and fix problems with Mantid not releasing memory

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: blocker Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description

To reproduce:

  • Load the CNCS_7860_event.nxs file in the repository
  • Open up the process monitor and note the memory usage
  • Click File->Clear all memory
  • The memory usage does not change

Change History

comment:1 Changed 9 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Martyn Gigg

Refs #4249.IFunctionMW now holds weak_ptr<Workspace> not a shared_ptr

This ensures that it does not keep a workspace alive unnecessarily, i.e in the FitBrowser where a function is long lived.

Changeset: 0d80c20dc9466056fc66c6524ec2778147030dea

comment:3 Changed 9 years ago by Martyn Gigg

Refs #4249. Fix for crash with LoadEmptyInstrument/makeEventWorkspace

The FitPropertyBrowser also crashed when fed an event workspace that has no X bounds. Fix for this situation.

Changeset: 0417a473648f6b656a45fd33e2aa6c05b4c6abb5

comment:4 Changed 9 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 9 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:6 Changed 9 years ago by Nick Draper

  • Status changed from verifying to closed

Tested with

  1. CNCS_7680_event
  2. argus0031800.nxs
  3. HET15869.raw
  4. example.spe

on Windows7 64 bit

All files release all memory (within an acceptable variance)

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5096

Note: See TracTickets for help on using tickets.