Ticket #4257 (assigned)
IndexSXPeaks
| Reported by: | Owen Arnold | Owned by: | Owen Arnold |
|---|---|---|---|
| Priority: | critical | Milestone: | Backlog |
| Component: | GUI | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: |
Description (last modified by Owen Arnold) (diff)
In addition to #4222, The ISIS SX scattering group have also produced a FindUBFromPeaks algorithm. As they are currently having little success using the existing UB Finding algorithms, they would like this algorithm refined and merged into the Mantid Code base.
This algorithm does not actually set the U or B matrix on the sample! This is the job of other algorightms such as CalculateU.
Change History
comment:3 Changed 9 years ago by Owen Arnold
refs #4257. Initial version of code ported across
Changeset: d4605a4a8a74d69a299781fac7b8edde09470e25
comment:4 Changed 9 years ago by Owen Arnold
refs #4257 Attempt to get algorithm working
Changeset: 83474bcbc5873738f1e0a3545d869ca784d03654
comment:5 Changed 9 years ago by Owen Arnold
refs #4257. Now have a working test set to develop against.
Refactoring of existing code and addtional checks introduced.
Changeset: 6c6ad6be5a7caebbecb9233c33be071348870397
comment:6 Changed 9 years ago by Owen Arnold
refs #4257. Extend tests and provide fixes.
Its now possible to provide SearchExtents for hkl. Helps prevent false positives.
Changeset: 1823afbdf4e08cfb2d7fb423f76e6d92dca8c2f8
comment:7 Changed 9 years ago by Owen Arnold
refs #4257. Give algorithm better name
Changeset: 16b5077dcf6de27febfc42eaca91139fe869878b
comment:8 Changed 9 years ago by Owen Arnold
refs #4257. Rename tests and make docs
Changeset: 771e029b912ecb759e88eb1447fde005bfeca568
comment:9 Changed 9 years ago by Owen Arnold
refs #4257 #4203. Fix GCC errors and warnings
Changeset: 254d448a5da5724c4fb970c448f31d78a4b82c07
comment:10 Changed 9 years ago by Owen Arnold
refs #4257 #4203. GCC Warning fixes.
Changeset: 808377e7a999c186c17f74bbabbb72b221d8ac69
comment:11 Changed 9 years ago by Owen Arnold
refs #4257 #4203. GCC Warning fixes.
Changeset: f8eb952c7f5d2439aab25fbdeaea2d973344579e
comment:12 Changed 9 years ago by Owen Arnold
- Description modified (diff)
- Summary changed from FindUBFromPeaks to IndexSXPeaks
comment:13 Changed 9 years ago by Owen Arnold
To Tester:
LoadIsawPeaks(Filename=r'AutoTestData/TOPAZ_3007.peaks',OutputWorkspace='loadedpeaks')
#To satisfy yourself that this algorithm is really working. At this point you open up the Peaks workspace in MantidPlot and 'clear the h,k,l values for the first 6 peaks'
IndexSXPeaks( PeaksWorkspace='loadedpeaks', a='14.131',b='19.300000000000001',c='8.6059999999999999', alpha='90',beta='105.071',gamma='90',PeakIndices='1,2,3,4,5,6', SearchExtents='-20,20,0,20,-20,20')
#Indexing algorithm will re-calculate and re-inject peaks, these should be identical to the original values deleted out.
comment:14 Changed 9 years ago by Owen Arnold
refs #4257. Default to all peaks if no indexes given.
Changeset: 1572b27f15f001382b11a7deb988ec168047c9a8
comment:15 Changed 9 years ago by Owen Arnold
refs #4257. Improve robustness of algorithm.
Changeset: 546015253854702d0c6d35b5a2ae46d501db14fc
comment:16 Changed 9 years ago by Owen Arnold
refs #4257. Fix type conversion warnings.
Changeset: b47055ae2acc9644daa2fb6e398e3291167a600a
comment:17 Changed 9 years ago by Owen Arnold
refs #4257. Handle non-indexing peaks.
Changeset: 234689d234d480d8327c79db47c4ba81770736b2
comment:18 Changed 9 years ago by Owen Arnold
refs #4257. Correct type usage warning
Changeset: 226ca47e1799549ca87353565cf93b5c65c3d2a4
comment:19 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 32 to Iteration 33
Moved to iteration 33 at iteration 32 code freeze
comment:20 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.1 to Release 2.2
Moved at end of release 2.1
comment:21 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.2 to Release 2.3
Moved at the end of release 2.2
comment:22 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.3 to Release 2.4
moved to Release 2.4
comment:23 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.4 to Release 2.5
Moved at the code freeze for release 2.4
comment:24 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.5 to Release 2.6
comment:28 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.6 to Backlog
Moved to the Backlog after R2.6
comment:29 Changed 7 years ago by Nick Draper
- Status changed from new to assigned
Bulk move to assigned at the introduction of the triage step
comment:30 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5104
I've upgraded this ticket to critical because Pascal is not having any success with the ISAW UBFinding algorithms and therefore his reduction pipeline is blocked!