Ticket #4258 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

LoadEventNexus slow for ISIS event files

Reported by: Martyn Gigg Owned by: Roman Tolchenov
Priority: major Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

Part of this is that the ISIS files only have one block of data defined so the parallel loading can't help. On this side can we consider reading the data in chunks as we do with the ISIS raw NeXus files? Probably needs discussion with Freddie.

The other issue here is that the extra work required for redistributing the events at the end of the load is taking the bulk of the time. Can this be parallelised or at least sped up?

A good example file LET00004286.nxs in cycle_11_4 on the ISIS archive.

On Windows I have found the VerySleepy program, http://www.codersnotes.com/sleepy, extremely helpful for call graph profiling.

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Owner set to Roman Tolchenov
  • Status changed from new to assigned

This is waiting on Freddie to start positioning the events in random positions within the bins, when he does so he will tell us the flag to check the file is doing this so we don't have to. -- Instant speed up.

comment:2 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:3 Changed 9 years ago by Nick Draper

Nick,

I am now randomising the events within a bin rather than putting them all at the bin centre – this behaviour is indicated by a new field in NXevent_data called "event_time_offset_shift" which will have the value "random" in such cases.

I have re-ended run WISH00020020 with this change in place, so WISH00020020.nxs on the central archive will have the usual all bin-centre events and
olympic\babylon5\scratch\freddie\WISH00020020_with_random_shift.nxs is the example with the random shifts applied Regards,

Freddie

comment:4 Changed 9 years ago by Roman Tolchenov

Re #4258. Skip randomization if data already random

Changeset: 74521c9b49d358e00a6aace539ff54b4de4c2480

comment:5 Changed 9 years ago by Roman Tolchenov

Re #4258. Skip randomization if data already random

Changeset: 74521c9b49d358e00a6aace539ff54b4de4c2480

comment:6 Changed 9 years ago by Roman Tolchenov

  • Status changed from assigned to accepted
  • Milestone changed from Iteration 33 to Iteration 32

comment:7 Changed 9 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:8 Changed 9 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:9 Changed 9 years ago by Martyn Gigg

  • Status changed from verifying to closed

Verified that the given WISH file drops from 80->6 seconds after after applying this fix.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5105

Note: See TracTickets for help on using tickets.