Ticket #4259 (assigned)

Opened 9 years ago

Last modified 5 years ago

Cleanup of ISIS SANS Script Code - Umbrella Ticket

Reported by: Anders Markvardsen Owned by: Peter Parker
Priority: major Milestone: Backlog
Component: SANS Keywords:
Cc: doucetm@… Blocked By: #4358, #8812
Blocking: Tester:

Description

A ticket for general cleanup of sans script code which does not fit into any other ticket

Change History

comment:1 Changed 9 years ago by Anders Markvardsen

  • Cc doucetm@… added
  • Status changed from new to accepted

comment:2 Changed 9 years ago by Anders Markvardsen

These no longer needed I believe. Re #4259

Changeset: e15357f528ec4db41a882fcd04c9b32083865f06

comment:3 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:4 Changed 8 years ago by Anders Markvardsen

A bit of cleanup in isis_instrument.py move_component. re #4259

Changeset: cdf59209c3f28a60088b2368a4dc7d80dd26acbf

comment:5 Changed 8 years ago by Anders Markvardsen

fix systemtests. re #4259

In my last attempt to cleanup isis sans script code I managed to introduce an error....

Changeset: cd00628d12dc80c7caa8807acfee06a3c48b22e0

comment:6 Changed 8 years ago by Anders Markvardsen

A bit of cleanup in isis_instrument.py move_component. re #4259

Changeset: cdf59209c3f28a60088b2368a4dc7d80dd26acbf

comment:7 Changed 8 years ago by Anders Markvardsen

fix systemtests. re #4259

In my last attempt to cleanup isis sans script code I managed to introduce an error....

Changeset: cd00628d12dc80c7caa8807acfee06a3c48b22e0

comment:8 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:9 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:10 Changed 8 years ago by Anders Markvardsen

  • Status changed from accepted to assigned
  • Owner changed from Anders Markvardsen to Gesner Passos

comment:11 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:12 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:13 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:14 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:15 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:16 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:17 Changed 7 years ago by Gesner Passos

  • Component changed from Framework to SANS

comment:18 Changed 7 years ago by Gesner Passos

  • Blocked By 4358 added

comment:19 Changed 7 years ago by Gesner Passos

  • Blocked By 8812 added

comment:20 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move to assigned at the introduction of the triage step

comment:21 Changed 7 years ago by Gesner Passos

Some things that could fit this ticket:

Remove or mark as deprecated these attributes/methods.

  • ISISReducer: DQY, PHIMIN, PHIMAX, PHIMIRROR, run_from_raw, step_num, Q_string, _temporys, _outputs, _workspace, _can, _tidy, output_workspaces, UID
  • ISISCommandInterface: UserPath, DataPath, CropToDetector, SetRearEfficiencyFile, SetFrontEfficiencyFile, displayUserFile, displayMaskFile, displayGeometry, LimitsPhi, LimitsQ, ViewCurrentMask, createColetteScript
  • SANSUtility: parseLogFile, normalizePhi, MaskInsideCylinder, ConvertToSpecList, MaskBySpecNumber, SetupTransmissionWorkspace, ScaleByVolume, StripEntZeroes, Orientation, WorkspaceDetails, RunDetails

comment:22 Changed 7 years ago by Gesner Passos

SANSUtility part is also in #6663

comment:23 Changed 7 years ago by Nick Draper

  • Owner changed from Gesner Passos to Peter Parker

Ownership handed over to Peter

comment:24 Changed 6 years ago by Peter Parker

  • Summary changed from SANS: cleanup of isis sans script code to Cleanup of ISIS SANS Script Code - Umbrella Ticket

comment:25 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5106

Note: See TracTickets for help on using tickets.