Ticket #4358 (closed: duplicate)

Opened 9 years ago

Last modified 5 years ago

SANS: python code cleanup for handling sample shapes

Reported by: Anders Markvardsen Owned by: Peter Parker
Priority: minor Milestone: Release 3.3
Component: SANS Keywords:
Cc: Blocked By:
Blocking: #4259 Tester: Anders Markvardsen

Description (last modified by Gesner Passos) (diff)

This includes getting rid of ScaleByVolume in

1) SANSUtility

2) The way height and width are set in GetSampleGeom in sans_reduction_steps is error prone because it assumes that the shape has been set prior to setting these

etc

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:2 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:3 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

http://www.mantidproject.org/Release_Notes_2_2_Full_List

comment:4 Changed 8 years ago by Anders Markvardsen

  • Status changed from new to assigned
  • Owner changed from Anders Markvardsen to Gesner Passos

comment:5 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to release 2.4

comment:6 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:7 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:8 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:9 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:10 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to the Backlog after the code freeze for R2.6

comment:11 Changed 7 years ago by Gesner Passos

  • Component changed from Framework to SANS
  • Description modified (diff)

comment:12 Changed 7 years ago by Gesner Passos

  • Blocking 4259 added

comment:13 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

bulk move to assigned at the into of the triage step

comment:14 Changed 7 years ago by Nick Draper

  • Owner changed from Gesner Passos to Peter Parker

Ownership handed over to Peter

comment:15 Changed 6 years ago by Peter Parker

Fixed in other tickets:

  • ScaleByVolume was deprecated elsewhere.
  • We now take extra-special care with Sample Geometry values.

comment:16 Changed 6 years ago by Peter Parker

  • Status changed from assigned to verify
  • Resolution set to fixed

comment:17 Changed 6 years ago by Peter Parker

  • Status changed from verify to reopened
  • Resolution fixed deleted
  • Milestone changed from Backlog to Release 3.3

comment:18 Changed 6 years ago by Peter Parker

  • Status changed from reopened to verify
  • Resolution set to duplicate

comment:19 Changed 6 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:20 Changed 6 years ago by Anders Markvardsen

  • Status changed from verifying to closed

comment:21 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5205

Note: See TracTickets for help on using tickets.