Ticket #4292 (closed: fixed)
TimeSeriesProperty inefficiencies
| Reported by: | Russell Taylor | Owned by: | Russell Taylor |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.0 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Wenduo Zhou |
Description
Some of the methods in TimeSeriesProperty are very inefficient, stepping through the whole map unnecessarily. getSingleValue is a case in point - it could make use the multimap member function 'upper_bound' instead.
As part of the the unit test coverage should be improved (getSingleValue has no test at present).
Change History
comment:2 Changed 9 years ago by Wenduo Zhou
Modify getSingleValue() for better efficiency. Refs #4292.
Changeset: 1cdbb761c561152ab4c24d8afca7fe3687c7c8e9
comment:3 Changed 9 years ago by Wenduo Zhou
- Owner changed from Wenduo Zhou to Russell Taylor
- Status changed from accepted to assigned
comment:5 Changed 9 years ago by Russell Taylor
Minor efficiency improvements. Re #4292.
Changeset: a57d67c543bd241c571679c08ce83f130b42bbd4
comment:6 Changed 9 years ago by Russell Taylor
- Status changed from accepted to verify
- Resolution set to fixed
Most other things look OK apart from those noted in the file - which would require a complete change in the way log filtering is done to improve upon.
Follow-up ticket #4409 has been created to enhance the unit test coverage.
