Ticket #4304 (closed: wontfix)

Opened 9 years ago

Last modified 5 years ago

Peformance investigations for NN Searching

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: minor Milestone: Release 2.3
Component: Mantid Keywords:
Cc: taylorrj@… Blocked By:
Blocking: Tester: Michael Reuter

Description

As part of iteration 32, worked on improving the speed of nearest neighbour searching #4038. Which had a very positive impact on it's performance, which I then tracked using a set of performance tests.

While working on ticket #4288. I degrated the performance by a small, but noticeable amount. This has been documented as part of #4288.

The likely cause of this is the increased number of .norm() calls made to V3D. Potential solutions to this are:

  • Store absolute distance as well as V3D of distances in nn map
  • Abandon the use of V3D distances, although this will result in loss of functionality
  • Actually do nothing and accept the small loss in performance

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:2 Changed 9 years ago by Mathieu Doucet

Re #4304 make ui loading more robust

Changeset: b74d992a892dff651b201513a71d0d77ecf96cbd

comment:3 Changed 9 years ago by Mathieu Doucet

Re #4304 fix broken reduction when bck is not subtracted from direct

Changeset: 5931273a764bf6742e300640fffb4644c89afa2e

comment:4 Changed 9 years ago by Mathieu Doucet

Re #4304 fix broken reduction when bck is not subtracted from direct

Changeset: 5931273a764bf6742e300640fffb4644c89afa2e

comment:5 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:6 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

http://www.mantidproject.org/Release_Notes_2_2_Full_List

comment:7 Changed 8 years ago by Owen Arnold

  • Status changed from new to verify
  • Resolution set to wontfix

I don't think that it's worth changing the way that this behaves for a minor improvement in the performance.

comment:8 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:9 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to closed

OK. The checkins seen here must have been meant for another ticket.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5151

Note: See TracTickets for help on using tickets.