Ticket #4327 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

OrientedLattice seems to permeate itself throughout the code

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: minor Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

I needed to make a small change to the UnitCell code and this caused a much large recompile that I expeceted. Sample was including OrientedLattice and a using Mantid::Geometry::OrientedLattice in a header. It can be forward declared and should be

Change History

comment:1 Changed 9 years ago by Martyn Gigg

Refs #4327. Remove OrientedLattice header from Sample.h

It is now forward declared and the dangerous using Mantid::Geometry::OrientedLattice has also been removed.

Changeset: 12ec10b095ad5b9b40695a9e497721efc141dcbb

comment:2 Changed 9 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:3 Changed 9 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 9 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:5 Changed 9 years ago by Russell Taylor

  • Status changed from verifying to closed

Tested by inspection and by modifying OrientedLattice.h and not observing lots of recompilation.

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5174

Note: See TracTickets for help on using tickets.