Ticket #4334 (closed: fixed)
Make GroupDetectors event aware
Reported by: | Stuart Campbell | Owned by: | Andrei Savici |
---|---|---|---|
Priority: | critical | Milestone: | Release 2.2 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Wenduo Zhou |
Description
Change History
comment:1 Changed 9 years ago by Nick Draper
- Status changed from new to assigned
- Owner set to Anyone
comment:2 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 32 to Iteration 33
Moved to iteration 33 at iteration 32 code freeze
comment:3 Changed 9 years ago by Andrei Savici
- Status changed from assigned to accepted
- Owner changed from Anyone to Andrei Savici
comment:5 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.1 to Release 2.2
Moved at end of release 2.1
comment:6 Changed 8 years ago by Andrei Savici
GroupDetectors is now event aware. Refs #4334
Changeset: dacb4354dfabb4e0800f97d56ea6f86017e8b5a3
comment:7 Changed 8 years ago by Andrei Savici
GroupDetectors2 test events. Refs #4334
Changeset: 3007068ce44466adcd73af4cf19ff3bf4d519886
comment:8 Changed 8 years ago by Andrei Savici
- Status changed from accepted to verify
- Resolution set to fixed
Check if number of events is OK. Check if average/sum works. Check if bin structure is preserved
comment:9 Changed 8 years ago by Mathieu Doucet
Re #4334 GroupDetectors is often used in a way that expects a MatrixWorkspace as output. Add option to keep events.
Changeset: 87d98f5a4a96abd9f4591f9c0373ce1d0bf3d7c4
comment:10 Changed 8 years ago by Mathieu Doucet
- Status changed from verify to reopened
- Resolution fixed deleted
comment:11 Changed 8 years ago by Mathieu Doucet
This algorithm is used at many places throughout the code. When it is, the output is usually expected to be a histogram. I've add a property to choose whether we want to keep events, with a default to false. Setting it to true will break one system test, but I know more areas of the code will break. If the default is to be changed to true, one should add the proper unit test, and go through all the c++ and python code using that algorithm and making sure that no calls such as workspace->dataY(i) is done on the output of GroupDetectors.
comment:12 Changed 8 years ago by Mathieu Doucet
Re #4334 Fix unit test
Changeset: 3441a70918e62d5f119e89aac7192c9294959bcf
comment:14 Changed 8 years ago by Mathieu Doucet
Re #4334 Protect against groupdetector changes
Changeset: cdcd991796e65f1456afc60bcd1e012975ea88f8
comment:15 Changed 8 years ago by Andrei Savici
GroupDetector keeps events by default. Refs #4334
Changeset: a56f2890e81df55a9827d2a7a5e8663ae93312af
comment:16 Changed 8 years ago by Andrei Savici
- Status changed from accepted to verify
- Resolution set to fixed
comment:17 Changed 8 years ago by Andrei Savici
GroupDetectors is now event aware. Refs #4334
Changeset: dacb4354dfabb4e0800f97d56ea6f86017e8b5a3
comment:18 Changed 8 years ago by Andrei Savici
GroupDetectors2 test events. Refs #4334
Changeset: 3007068ce44466adcd73af4cf19ff3bf4d519886
comment:19 Changed 8 years ago by Mathieu Doucet
Re #4334 GroupDetectors is often used in a way that expects a MatrixWorkspace as output. Add option to keep events.
Changeset: 87d98f5a4a96abd9f4591f9c0373ce1d0bf3d7c4
comment:20 Changed 8 years ago by Mathieu Doucet
Re #4334 Fix unit test
Changeset: 3441a70918e62d5f119e89aac7192c9294959bcf
comment:21 Changed 8 years ago by Mathieu Doucet
Re #4334 Protect against groupdetector changes
Changeset: cdcd991796e65f1456afc60bcd1e012975ea88f8
comment:22 Changed 8 years ago by Wenduo Zhou
- Status changed from verify to verifying
- Tester set to Wenduo Zhou
comment:24 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5181