Ticket #4335 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Clean up inherited qtiplot python imports

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: major Milestone: Release 2.0
Component: MantidPlot Keywords:
Cc: martyn.gigg@… Blocked By:
Blocking: Tester: Janik Zikovsky

Description

I propose to remove the qtiplotrc.py startup script (and qtiUtils.py as well). This was prompted by the fact that I was having trouble running 2 scripts (i.e. this and mantidplotrc.py) when launching IPython, but looking into the file I think very little of it is actually needed. Anything that is can go into mantidplotrc.py.

Also, I want to thin out qti.sip by removing the parts that aren't applicable to MantidPlot. This is primarily the exposure of QtiPlot's fitting classes.

Change History

comment:1 Changed 9 years ago by Martyn Gigg

I agree, the script basically just imports certain things into the main namespace and we don't use it a large amount of it, especially the maths functions. As for qti.sip, I think it can only benefit from a clean up.

comment:2 Changed 9 years ago by Russell Taylor

  • Status changed from new to accepted

comment:3 Changed 9 years ago by Russell Taylor

Remove exposure of qtiPlot's fitting classes to Python. Re #4335.

These were inherited from qtiPlot and Mantid users should be using our fitting mechanism instead.

Changeset: e43a39a13829c44cbb4cd979264175eaa3db8f80

comment:4 Changed 9 years ago by Russell Taylor

Remove python access to QtiPlot's 'Note'. Re #4335.

Changeset: f4819ef2cca70b7905c5d1a4ce69158ee8d81842

comment:5 Changed 9 years ago by Russell Taylor

I'm not sure about the 'Filter' classes. I could see how they could be useful for post-reduction analysis, but maybe we should encourage all analysis to go through Mantid algorithms. I've no idea if anyone's using them (probably unlikely), or come to that whether they actually work.

comment:6 Changed 9 years ago by Russell Taylor

Revert "Remove python access to QtiPlot's 'Note'. Re #4335."

I've updated Note to be simpler and need it to complete the port of stem plots. Re #4341 & #2654.

This reverts commit f4819ef2cca70b7905c5d1a4ce69158ee8d81842.

Changeset: 49aacc4d97898585b255c1edb50580f06542792a

comment:7 Changed 9 years ago by Russell Taylor

Re-order method declarations to be less random. Re #4335.

Changeset: fb119674d155bbcea70a0ede18467fb06f244022

comment:8 Changed 9 years ago by Russell Taylor

Remove python exposure of QtiPlot 'Filter' classes. Re #4335.

Making the assumption that no-one uses them....

Changeset: 1b49f1206ddf38fc002063887f7227f826137acf

comment:9 Changed 9 years ago by Russell Taylor

Remove qtiplotrc.py startup file. Re #4335.

And qtiUtil.py as well. We hardly used anything in them. The only thing we did was the import of functions from the qti module into the global namespace. This will be replaced by proxy methods to prevent crashes if objects are deleted (see #1037).

Changeset: 87a32aceead0a4ee6f732fe45768253731926d19

comment:10 Changed 9 years ago by Russell Taylor

Remove deleted file from Windows installer. Re #4335.

Changeset: 6d5811443f8cdb359ec6c51a17fa3bec098af1a9

comment:11 Changed 9 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:12 Changed 9 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:13 Changed 9 years ago by Janik Zikovsky

  • Status changed from verifying to closed

qti.sip is cleaned up and qtiplotrc.py is gone.

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5182

Note: See TracTickets for help on using tickets.