Modify NormalizeByMonitor algorithm to work with spectra-detecror map

[Alex Buts]

Tickets #4098 --> fixed the error with spectra-detector map, but initial purpose to be able both use spectra map and monitor map has not been implemented yet.

New option, which should deal with monitor names rather then spectra numbers should be provided.

1) Needed to verify if it works correctly both for MARI and for MERLIN e.g the list of the monitors, displayed in the list box do not correspond to monitors spectra. (something to do with spectra-detectors map?)

2) The option to normalize by any detector's spectra has to be provided.

3) Unit tests to verify the code have to be expanded.

[Alex Buts]

The Ron's comment:

A crash occurs if a certain (incorrect) sequence of commands is given: (1) load a data set such as MAR11001.raw into MantidPlot. (2) execute NormaliseToMonitor setting an output workspace and an (incorrect) MonitorWorkspace, e.g. MAR11001. This fails to run and reports correctly that the MonitorWorkSpace must contain only 1 spectra. (3) Run the algorithm a second time and reset the MonitorWorkspace to null. When this is run MantidPlot crashes with a segmentation fault on both RHEL5 and Windows32. This seems to be a problem with the treatment of parameters in the GUI. This bug also exists in the previous release version of Mantid, so it is not related to the changes made by this ticket.

should be looked at too.

[Alex Buts]

refs #4400 Intermediate changes returned algo to working state

Changeset: 5e79f872eed68bb3192ab56888bac6aefbe67d71

[Alex Buts]

refs #4400 Some reasonable changes to Algorithm

1) readMonotorID function reads only existing monitors. 2) ws without monitor's spectra returns empty validator 3) Some unit tests

Changeset: 92ea8ea665f2ef33c67acc620e0ebaa2af935c60

[Alex Buts]

refs #4400 Monitors Ws property depends on spectra property

Changeset: 11dd91bbe284a4bca1f5255ea8026e965a21efda

[Alex Buts]

refs #4400 Fixing Unix warnings

Changeset: 6c7e27ab8814d1d89523709846ed58050508fdd2

[Alex Buts]

refs #4400 proper relation between all properties

reflected in gui and in algorithm itself

Changeset: ea8e42d3eb23ef6eb9b778944a3e5737fc202c77

[Alex Buts]

refs #4400 mainly fixes it.

A bit more tests would be useful.

Changeset: 7dc3832006854d7a937153907480484bd37af8c8

[Alex Buts]

refs #4400 Added more unit tests

Actually there are tests which should test main logic. Not fully comprehensive, but enough for the time being.

Changeset: 6a6eb5d218332405f5095156711d2873b6007cb4

[Alex Buts]

refs #4400 A bit more unit tests

and some minor enhancements.

Changeset: d8806c29ee4f8414d12b32a68dcc7c749177ac10

[Alex Buts]

refs #4400 Intermediate changes returned algo to working state

Changeset: 5e79f872eed68bb3192ab56888bac6aefbe67d71

[Alex Buts]

refs #4400 Some reasonable changes to Algorithm

1) readMonotorID function reads only existing monitors. 2) ws without monitor's spectra returns empty validator 3) Some unit tests

Changeset: 92ea8ea665f2ef33c67acc620e0ebaa2af935c60

[Alex Buts]

refs #4400 Monitors Ws property depends on spectra property

Changeset: 11dd91bbe284a4bca1f5255ea8026e965a21efda

[Alex Buts]

refs #4400 Fixing Unix warnings

Changeset: 6c7e27ab8814d1d89523709846ed58050508fdd2

[Alex Buts]

refs #4400 proper relation between all properties

reflected in gui and in algorithm itself

Changeset: ea8e42d3eb23ef6eb9b778944a3e5737fc202c77

[Alex Buts]

refs #4400 mainly fixes it.

A bit more tests would be useful.

Changeset: 7dc3832006854d7a937153907480484bd37af8c8

[Alex Buts]

refs #4400 Added more unit tests

Actually there are tests which should test main logic. Not fully comprehensive, but enough for the time being.

Changeset: 6a6eb5d218332405f5095156711d2873b6007cb4

[Alex Buts]

refs #4400 A bit more unit tests

and some minor enhancements.

Changeset: d8806c29ee4f8414d12b32a68dcc7c749177ac10

[Alex Buts]

refs #4400 More comments

Changeset: 1fa3c13aad9b5ecfd634650e32a42033ec032e32

[Alex Buts]

refs #4400 Minor changes due to merging

Changeset: 3ef57f2a4d13b31d68780600d602bfc04af35441

[Russell Taylor]

Re #4400. Clear intel compiler warning.

Changeset: 75078ab994d4d0d03e8515cccac0887c84ae158e

[Alex Buts]

refs #4400 Inrelated minor changes to the Code

as Typed Validator was not in cmake list so was not visible in IDE.

Changeset: 4749f3020fe0e837e339100d2157757c45cc02b4

[Alex Buts]

refs #4400 minor changes and comments

Changeset: ea2fa1c8a43fe4b23e0ca39b840dd3618edbab76

[Alex Buts]

refs #4400 More comments

Changeset: 1fa3c13aad9b5ecfd634650e32a42033ec032e32

[Alex Buts]

refs #4400 Minor changes due to merging

Changeset: 3ef57f2a4d13b31d68780600d602bfc04af35441

[Russell Taylor]

Re #4400. Clear intel compiler warning.

Changeset: 75078ab994d4d0d03e8515cccac0887c84ae158e

[Alex Buts]

refs #4400 Inrelated minor changes to the Code

as Typed Validator was not in cmake list so was not visible in IDE.

Changeset: 4749f3020fe0e837e339100d2157757c45cc02b4

[Alex Buts]

refs #4400 minor changes and comments

Changeset: ea2fa1c8a43fe4b23e0ca39b840dd3618edbab76

[Alex Buts]

To testers:

Please, pay attention to the crash, which was probably observed in ticket #4893 too and hopefully fixed there.

[Alex Buts]

refs #4400 returned property optimization

which have probably over cautiously disabled when dealing with #4893

Changeset: 65403070c01d6c9805999de32655d80c83ba5783

[Martyn Gigg]

Noted the existence of the new MonitorID property, which is what is referred to in the description as detector names.

Using a different detector ID does indeed produce a different normalization.

It should be noted that the behaviour in the crash is now not the exact behaviour that occurs. The crash has been fixed but the algorithm no longer throws if a workspace has more than 1 spectrum due to the WorkspaceIndex properties.

[Alex Buts]

refs #4400 returned property optimization

which have probably over cautiously disabled when dealing with #4893

Changeset: 65403070c01d6c9805999de32655d80c83ba5783

[Stuart Campbell]

This ticket has been transferred to github issue ​5247