Ticket #4443 (closed: fixed)
Ask about rectangular detectors
| Reported by: | Owen Arnold | Owned by: | Arturs Bekasovs |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.6 |
| Component: | Framework | Keywords: | Student |
| Cc: | Blocked By: | ||
| Blocking: | #6067, #7441 | Tester: | Owen Arnold |
Description
We could do with a top level bool method on an instrument to ask whether the instrument contains rectangular detectors. This would be useful in places such as SmoothNeighbours where we assume rectangular detectors if the radius < 0.
Change History
comment:2 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.2 to Release 2.3
Moved at the end of release 2.2
comment:3 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.3 to Release 2.4
Moved to milestone 2.4
comment:4 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.4 to Release 2.5
Moved at the code freeze for release 2.4
comment:7 Changed 7 years ago by Martyn Gigg
it should return Full, Partial or None, and should ignore monitors. Talk to Owen about using it in SmoothNeighbours
comment:8 Changed 7 years ago by Martyn Gigg
- Owner changed from Anyone to Arturs Bekasovs
- Status changed from new to assigned
comment:10 Changed 7 years ago by Arturs Bekasovs
comment:11 Changed 7 years ago by Arturs Bekasovs
comment:12 Changed 7 years ago by Arturs Bekasovs
comment:13 Changed 7 years ago by Arturs Bekasovs
Added some code so it is possible to test from MantidPlot
Refs #4443
Changeset: fa621d1fa535d70e43657eb696b0921e9d289c2f
comment:15 Changed 7 years ago by Arturs Bekasovs
Moved debugging code to more appropriate place
Refs #4443
Changeset: 5e83ab2a2374c77556ef136ea3489c68ed1b64f2
comment:16 Changed 7 years ago by Arturs Bekasovs
Merge branch 'feature/4443_rectangular_detectors' into develop
Conflicts:
Code/Mantid/Framework/Geometry/src/Instrument.cpp
Refs #4443
Changeset: 903c051c5d3cc7b507011cb65b2afc65f5cabd04
comment:17 Changed 7 years ago by Arturs Bekasovs
- Status changed from accepted to verify
- Resolution set to fixed
Branch: feature/4443_rectangular_detectors
Tester: Apart from the unit tests, I've added some code to the SmoothNeighbours so it is possible to check whether real instruments are classified correctly.
To test it, in MantidPlot load a workspace with instrument defined, enable Debug level of the log console, run SmoothNeighbours (using Radius 5) on the workspace loaded and notice the debug message (one of the listed below).
Expected results:
- SystemTests/Data/TOPAZ_3007_bank_37_20_sec.nxs = "Consists of rectangular detectors".
- AutoTestData/LOQ49886.nxs = "Partially consists of rectangular detectors".
- AutoTestData/CNCS_7860_event.nxs = "No rectangular detectors"
comment:18 Changed 7 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:19 Changed 7 years ago by Owen Arnold
refs #4443. Solve merge conflict.
Changeset: 0742f16075721bbac0795f98294c74ff05167bb4
comment:20 Changed 7 years ago by Owen Arnold
All these tests pass. I also tested that it works on the WISH instrument, and it does what I expect.
In general, this has been very well implemented.
comment:22 Changed 7 years ago by Nick Draper
- Blocking 6067 added
(In #6067) Subtickets for this are in the Blocked By list.
This ticket is complete when they are!
comment:24 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5290
Moved at end of release 2.1