Change the SendTo settings so that a tick box indicates which programs will be visible in the list.

[Robert Whitley]

Go to Preferences -> Mantid -> Send To

The check boxes currently indicate which one is selected so that the user can delete or edit them.

This should be changed so that it indicates which ones will be shown in the list of programs a workspace can be sent to.

[Nick Draper]

Moved at end of release 2.1

[Nick Draper]

http://www.mantidproject.org/Release_Notes_2_2_Full_List

[Nick Draper]

Moved to release 2.4

[Nick Draper]

Moved at the code freeze for release 2.4

[Nick Draper]

Moved to r2.6 at the end of r2.5

[Keith Brown]

Send to options working more sensibly

Changes have been made to the tree in View->Preferences->Mantid->Send To so that it opperates more sensibly, in specific: Checkboxes in the tree now switch visibility in the menu on or off. the "visible" option in the edit dialog has been removed in favor of using the tree checkboxes. selection to edit is now made by selecting the item rather then clicking the checkbox. functionality of ConfigDialog::createCheckedTreeItem now makes sence based on the parameters, passing true as the second paramter will now produce a checked item. This will have broken some other functions that use, it, but it'll only require that i negate their current value they pass.

Refs #4495

Changeset: cbab5dec3d699be4a3a7191453bf6b67bf6044b3

[Keith Brown]

New bug discovered #7439 : Discovered that remove functionality will cause an error if the program hasn't been restarted due to ConfigService returning removed values.

[Keith Brown]

Multi-select functionality restored

The ability to select multiple programs (used for deletion) has been restored

Refs #4495

Changeset: 5abcb5f48534cab04ae0810e2cfc7a1b02c7202a

[Keith Brown]

Negated affected function calls

My edit to createCheckedTreeItem meant that i had to negate the second parameter to restore functionality to normal prior to the change

Refs #4495

Changeset: 1aa78870cf67fecd249d35247af4b866118b8fd9

[Keith Brown]

To Test:

Go into the Send To options in View->Preferences->Mantid->Send To

Any visible programs should be checked.

When nothing is selected, "Edit" and "Delete" should be disabled.

When editing an existing program or adding a new program, the "Visible" checkbox should no longer be present.

Select a single item without touching the checkbox, "Edit" and "Delete" should become active.

Add some new programs to the send to list, they will default to checked.

Load a workspace and right click it, the new programs should be there and any unavailable programs shouldn't.

Uncheck some checkboxes in the options, and check Send To again, those programs should be no longer present in the list.

Use ctrl to select multiple programs, "Edit" should be disabled, "Delete" should be active.

When one of more programs are selected pressing "Delete" should remove them from this list (make sure you close and re-open MadtidPlot before going to the send to menu after doign this otherwise you'll encounter #7439)

Check Send To again (after closing and re-opening the program), those programs should be no longer present in the list if they were originally checked.

[Keith Brown]

Forgot to put it onto the build servers

[Keith Brown]

Has passed on the build servers, ready to be tested.

[Mathieu Doucet]

If you uncheck a box, the "Edit" and "Delete" buttons are enabled, as expected. But re-checking the box does not disable them.

[Keith Brown]

Just to make sure of the distinction, I've just checked and unchecked a box and i see no problem with that aspect of it's behavior. It should keep the edit and delete buttons active, as their active/disabled trigger is no longer the checkboxes but selected rows, and unchecking or checking a checkbox won't automatically select that row. Multiple selection is done via ctrl or shift. Can I just get clarification on what you meant or if my explanation there now invalidates your complaint?

However, i did find a problem that when I deselect by clicking elsewhere in the box it doesn't deactivate them, so I'll get on fixing that.

[Keith Brown]

Fixed bug with deselection and added select on check/uncheck

There was potential for a crash as deselecting didn't disable the edit/delete buttons, adding another signal handler has sorted this

New behavior where checking or uncheckign a checkbox will automaticaly select that item has been added.

Refs #4495

Changeset: 7273f4e449f6d360f541d5d934ddf353b948fbbf

[Keith Brown]

Removed a redundant method and changed some signals

ConfigDialog::treeSelecting has been removed as it did the same as QTreeWidget.selectedItems() did after i had changed the functionality from looking at checkboxes to looking at the selection.

The signal for looking at checkboxes has been changed. The class now has methods that respond to SelectionChanged() to make the deselection work, and the ItemClicked handler now responds to ItemChanged instead as that should only fire when a checkbox is changed or the item itself is changed. I'll have to look at it's behaviour after an Edit or deletion as i suspect it may need more work.

ConfigDialog::TreeClicked() has been renamed ConfigDialog::itemCheckedChanged()

The order the GUI is built in initSendToProgramTab() has been changed to add the buttons first, then the tree. as well as only connecting the signal handlers to the tree when everything else is initialised to stop problems where the handlers are trying to reference other GUI elements before they're initialised.

Refs #4495

Changeset: c6177731b32587558e0854ea777fb78bb382fff1

[Keith Brown]

Edit and delete working as expected, now waiting for tester to respond to enquiry

[Keith Brown]

Fixed a compiler error in Ubuntu

For some reason a definition that visual studio allowed, Eclipse didn't and it wouldn't compile.

Refs #4495

Changeset: 7faeb64411d3ae06ff9e5b36e8b181fddb59c81b

[Mathieu Doucet]

Works as described.

[Stuart Campbell]

This ticket has been transferred to github issue ​5342