Ticket #7439 (assigned)

Opened 7 years ago

Last modified 5 years ago

ConfigService getKeys returns removed values

Reported by: Keith Brown Owned by: Anders Markvardsen
Priority: critical Milestone: Backlog
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester:

Description (last modified by Nick Draper) (diff)

If m_pConf has keys that have been removed, getKeys(const std::string& keyName) will still return them. Happens on Windows at least, unconfirmed in Linux and Mac.

Presumably related to the try-catch block catching an exception thrown by getString

Discovered when fixing #4495 as it caused an error when populating the "Send To" menu after deleting a program from the "Send To" list (without restarting the program) as GetKeys was returning the items that had been deleted (or at least marked with the removed flag)

Change History

comment:1 Changed 7 years ago by Keith Brown

  • Summary changed from ConfigService returns removed values to ConfigService getKeys returns removed values

comment:2 Changed 7 years ago by Russell Taylor

  • Blocking 4445 added

(In #4445) I suppose this should properly be tested when #7439 is fixed, so I'll sit on it for a while at least.

comment:3 Changed 7 years ago by Nick Draper

  • Owner set to Anders Markvardsen
  • Status changed from new to assigned
  • Description modified (diff)

comment:4 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:5 Changed 7 years ago by Keith Brown

Also affects the Send To tab of the Mantid preferences.

Deleting an item takes it off the list, then press ok, re-open the preferences and you'll find that the deleted items are back

comment:6 Changed 7 years ago by Anders Markvardsen

  • Priority changed from major to critical

comment:7 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Release 3.0

comment:8 Changed 7 years ago by Anders Markvardsen

  • Milestone changed from Release 3.0 to Release 3.1

comment:9 Changed 7 years ago by Russell Taylor

  • Blocking 4445 removed

(In #4445) Got bored of waiting for 7439 so mentally verified that this refers to the same issue.

comment:10 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 3.1 to Backlog

Moved to backlog at the end of Release 3.1

comment:11 Changed 7 years ago by Anders Markvardsen

  • Milestone changed from Backlog to Release 3.2

comment:12 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state

comment:13 Changed 6 years ago by Anders Markvardsen

  • Milestone changed from Release 3.2 to Backlog

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8285

Note: See TracTickets for help on using tickets.