Ticket #488 (closed: duplicate)
SANS: Add new masking shapes
Reported by: | Russell Taylor | Owned by: | Anders Markvardsen |
---|---|---|---|
Priority: | minor | Milestone: | Release 2.0 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Nick Draper |
Description
Just needs the definition of an appropriate shape as input to the MaskDetectorsByShape algorithm. They typically mask symmetrically on either side of the detector (so keep detectors where |angle|<phi and |angle-pi|<phi.
Change History
comment:1 Changed 12 years ago by Russell Taylor
- Summary changed from SANS: Add ability to mask by phi to SANS: Add new masking shapes
comment:2 Changed 11 years ago by Nick Draper
- Milestone changed from Iteration 16 to Iteration 17
Batch move of tickets to Iteration 17
comment:3 Changed 11 years ago by Nick Draper
- Milestone changed from Iteration 17 to Iteration 18
Moved as part of iteration end
comment:4 Changed 11 years ago by Nick Draper
- Milestone changed from Iteration 18 to Iteration 19
Moved as part of iteration 18 end
comment:5 Changed 11 years ago by Nick Draper
- Priority changed from major to minor
- Milestone changed from Iteration 19 to Iteration 20
comment:6 Changed 10 years ago by Nick Draper
- Milestone changed from Iteration 26 to Iteration 27
Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.
comment:7 Changed 10 years ago by Nick Draper
- Milestone changed from Iteration 27 to Iteration 28
Bulk move of tickets at the end of iteration 27
comment:8 Changed 10 years ago by Russell Taylor
- Owner changed from Russell Taylor to Steve Williams
- Status changed from new to assigned
- Component set to Mantid
- Milestone changed from Iteration 28 to Iteration 30
Needs input from ISIS SANS team.
comment:9 Changed 9 years ago by Anders Markvardsen
- Owner changed from Steve Williams to Anders Markvardsen
Phi masking has been done - #2780
comment:10 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 30 to Iteration 31
Bulk move of tickets to iteration 31 at the iteration 30 code freeze
comment:11 Changed 9 years ago by Anders Markvardsen
- Status changed from assigned to accepted
Fixed in #3015
comment:12 Changed 9 years ago by Anders Markvardsen
- Status changed from accepted to verify
- Resolution set to duplicate
comment:13 Changed 9 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
duplicate verified
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 1336
Needs the definition of appropriate shapes as input to the MaskDetectorsByShape algorithm.
First the easy one - masking by phi:
They typically mask symmetrically on either side of the detector (so keep detectors where |angle|<phi and |angle-pi|<phi).
Then the harder one:
On Sans-2d, after the sample comes first a circular aperture and then a set of jaws that create a rectangular opening. We need to project the masking due to these onto the detector banks (which can move). Although a first cut can treat the sample as a point, in reality it isn't and this should be taken into account.