Ticket #4899 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

MedianDetectorTest should allow for specific levels of the instrument

Reported by: Peter Peterson Owned by: Andrei Savici
Priority: major Milestone: Release 2.1
Component: Mantid Keywords:
Cc: scu@… Blocked By:
Blocking: Tester: Janik Zikovsky

Description

Since it is frequently desired to compare to the median value of the tube/bank/row rather than the full instrument, add a parameter that allows the user to select this with the default being the whole instrument. The parameter should specify the number of levels above pixel to calculate the median as an integer.

Attachments

cncs_level1.png (35.8 KB) - added by Janik Zikovsky 8 years ago.

Change History

comment:1 Changed 9 years ago by Andrei Savici

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Andrei Savici

MedianDetectorTest allows testing by tube. Refs #4899

Changeset: 95aba4f928a4f87b4fe5fe752babbe818c245585

comment:3 Changed 9 years ago by Andrei Savici

Fix Windows int vs size_t for MedianDetectorTest. Refs #4899

Changeset: d0e4cadd760541a50f99b0ab53250c4e5f97b891

comment:4 Changed 8 years ago by Peter Peterson

This needs to be integrated into the DetectorDiagnostic algorithm before it can be closed. A couple of problems I have already had:

  • DetectorDiagnostic already integrates the workspace (once to save everybody time) and the InputWorkspace validator does not like it.
  • It doesn't appear to work for NOMAD data when LevelsUp=1. The error it produces is (with a nice typo) "no single valid histohrams identified in the workspace".

comment:5 Changed 8 years ago by Andrei Savici

Median set to 0 instead of throwing. Refs #4899

Changeset: 97f3695ba561b16d1aaeefb40c4079d231ff3354

comment:6 Changed 8 years ago by Andrei Savici

Median set to 0 instead of throwing. Refs #4899

Changeset: 97f3695ba561b16d1aaeefb40c4079d231ff3354

comment:7 Changed 8 years ago by AndreiSavici

Lower log level for calculating median. Refs #4899

Changeset: fc886e18a135d251b1774f364e84d57d60dede38

comment:8 Changed 8 years ago by AndreiSavici

Lower log level for calculating median. Refs #4899

Changeset: fc886e18a135d251b1774f364e84d57d60dede38

comment:9 Changed 8 years ago by Andrei Savici

Wiki will be updated during the testing period. No unit tests for this new feature.

comment:10 Changed 8 years ago by Andrei Savici

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:11 Changed 8 years ago by Andrei Savici

Updated wiki for MedianDetectorTest. Refs #4899

Changeset: aa3dd5ad87dbd5c4a4d79a1acc7ba84cd495f681

comment:12 Changed 8 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:13 Changed 8 years ago by Martyn Gigg

  • Status changed from verifying to verify
  • Tester Martyn Gigg deleted

I can't test this with any ISIS data we have as it doesn't seem to cope with grouping of detectors, it simple throws an error. Not required for ISIS at the moment so see #5241

comment:14 Changed 8 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:15 Changed 8 years ago by Janik Zikovsky

Made ticket #5245 so you wouldn't forget to add a unit test :)

comment:16 Changed 8 years ago by Janik Zikovsky

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Ticket #5074 really needs to be resolved for this algo to be considered working. Also, with LevelsUp=1 the results looked funny. Will attach screenshot.

Changed 8 years ago by Janik Zikovsky

comment:17 Changed 8 years ago by Andrei Savici

  • Status changed from reopened to accepted

Ticket #5074 fixed the masking problem. The funny image is due to the fact that you need to exclude zeros from median.

comment:18 Changed 8 years ago by Andrei Savici

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:19 Changed 8 years ago by Janik Zikovsky

  • Status changed from verify to verifying

comment:20 Changed 8 years ago by Janik Zikovsky

  • Status changed from verifying to closed

Works if you exclude zeros or use more data than the small CNCS file I was using.

comment:21 Changed 8 years ago by Andrei Savici

Updated wiki for MedianDetectorTest. Refs #4899

Changeset: aa3dd5ad87dbd5c4a4d79a1acc7ba84cd495f681

comment:22 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5745

Note: See TracTickets for help on using tickets.