Generalized delta Dirac fitting function

[Jose Borreguero]

A delta Dirac with a pre-factor that can be a function of the declared parameters.

[Jose Borreguero]

The easiest solution is to add a virtual function to class DeltaFunction:

virtual double HeightPrefactor()const { return 1.0; }

HeightPrefactor can be overwritten for each derived class with a function of declared parameters.

[Jose Borreguero]

Refs #4921 HeightPrefactor function in DeltaFunction class

Changeset: 0ab62ae86b519c9f3f13e36d3c8afa8763ecb548

[Jose Borreguero]

Refs #4921 HeightPrefactor function in DeltaFunction class

Changeset: 0ab62ae86b519c9f3f13e36d3c8afa8763ecb548

[Anders Markvardsen]

I will pass this ticket since the DiffSphere unit tests are working.

However, I have a number of suggestions/concerns:

1. The comment in:

virtual double HeightPrefactor()const { return 1.0; } modulates the Height of the Delta function

This code comment is note stating that this method only is applied in the context of convolution.

2. If this method stays please change its name from HeightPrefactor to heightPrefactor

3. Perhaps there is a good reason for this, which I just can't see, but why do you need this extra method, and why only have it applied in convolution? Let me know if you would like a chat about this after the release.

4. There is no DiffSphere wiki page

[Stuart Campbell]

This ticket has been transferred to github issue ​5767