Ticket #4921 (closed: fixed)
Generalized delta Dirac fitting function
Reported by: | Jose Borreguero | Owned by: | Jose Borreguero |
---|---|---|---|
Priority: | major | Milestone: | Release 2.1 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Anders Markvardsen |
Description
A delta Dirac with a pre-factor that can be a function of the declared parameters.
Change History
comment:2 Changed 9 years ago by Jose Borreguero
Refs #4921 HeightPrefactor function in DeltaFunction class
Changeset: 0ab62ae86b519c9f3f13e36d3c8afa8763ecb548
comment:3 Changed 9 years ago by Jose Borreguero
Refs #4921 HeightPrefactor function in DeltaFunction class
Changeset: 0ab62ae86b519c9f3f13e36d3c8afa8763ecb548
comment:5 Changed 9 years ago by Jose Borreguero
- Status changed from accepted to verify
- Resolution set to fixed
comment:6 Changed 8 years ago by Anders Markvardsen
- Status changed from verify to verifying
- Tester set to Anders Markvardsen
comment:7 Changed 8 years ago by Anders Markvardsen
- Status changed from verifying to closed
I will pass this ticket since the DiffSphere unit tests are working.
However, I have a number of suggestions/concerns:
- The comment in:
virtual double HeightPrefactor()const { return 1.0; } modulates the Height of the Delta function
This code comment is note stating that this method only is applied in the context of convolution.
- If this method stays please change its name from HeightPrefactor to heightPrefactor
- Perhaps there is a good reason for this, which I just can't see, but why do you need this extra method, and why only have it applied in convolution? Let me know if you would like a chat about this after the release.
- There is no DiffSphere wiki page
Note: See
TracTickets for help on using
tickets.
The easiest solution is to add a virtual function to class DeltaFunction:
HeightPrefactor can be overwritten for each derived class with a function of declared parameters.