Ticket #4940 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

SANS: Enable add files to be loaded

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: blocker Milestone: Release 2.1
Component: MantidPlot Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description


Change History

comment:1 Changed 9 years ago by Anders Markvardsen

Enable loading of add file in isis sans. re #4940

Changeset: 7231b627575aeb1b1c1aef5b8c9f3153fe2e0a2d

comment:2 Changed 9 years ago by Anders Markvardsen

Add isis tab - now create working hist from event. re #4940

Changed python code to after event files has been added that the result of this is converted to a histogram ws that isis sans can read

Changeset: 7b38c16013beb7126a9b2ee7f4d49c434b85c380

comment:3 Changed 9 years ago by Anders Markvardsen

Update to gui for user add binning. re #4940

Changeset: caad5866919a72ab62f317ae447471652bea7ab2

comment:4 Changed 9 years ago by Anders Markvardsen

Enable loading of add file in isis sans. re #4940

Changeset: 7231b627575aeb1b1c1aef5b8c9f3153fe2e0a2d

comment:5 Changed 9 years ago by Anders Markvardsen

Add isis tab - now create working hist from event. re #4940

Changed python code to after event files has been added that the result of this is converted to a histogram ws that isis sans can read

Changeset: 7b38c16013beb7126a9b2ee7f4d49c434b85c380

comment:6 Changed 9 years ago by Anders Markvardsen

Update to gui for user add binning. re #4940

Changeset: caad5866919a72ab62f317ae447471652bea7ab2

comment:7 Changed 9 years ago by Anders Markvardsen

  • Status changed from new to accepted

Sarah/Richard (instrument scientists on SANS2D) varied that this now works.

comment:8 Changed 9 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

To test e.g. add SANS2D run 11109 and 11110 together using the ISIS SANS Add Runs tab. This produces a file which you can e.g. subsequently just load in Mantid or run a 1D reduce on.

Note that Sarah/Richard will use this feature frequently for the rest of this cycle.

comment:9 Changed 8 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:10 Changed 8 years ago by Martyn Gigg

The add tab no longer seems to work. If you add some files to the list and click sum you get a dialog box saying there was a problem adding the files. I believe it is due to this, which is printed out in the console window when I rerun it in my debug build.

Object::connect: No such signal MantidQt::CustomInterfaces::SANSAddFiles::runAsPythonScript(const QS
tring&) in ..\..\..\..\src\mantid\Code\Mantid\MantidQt\CustomInterfaces\src\SANSAddFiles.cpp:68
Object::connect:  (receiver name: 'SANSRunWindow')
Object::connect: No such signal MantidQt::CustomInterfaces::SANSDiagnostics::runAsPythonScript(const
 QString&) in ..\..\..\..\src\mantid\Code\Mantid\MantidQt\CustomInterfaces\src\SANSDiagnostics.cpp:6
1

comment:11 Changed 8 years ago by Martyn Gigg

This is due to the changes for running Python asynchronously. It's a pain that Qt only produces text warnings for signal mismatches as they are too easily missed. As I made the async changes I'll fix it.

comment:12 Changed 8 years ago by Martyn Gigg

  • Status changed from verifying to reopened
  • Resolution fixed deleted

comment:13 Changed 8 years ago by Anders Markvardsen

  • Status changed from reopened to accepted

comment:14 Changed 8 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:15 Changed 8 years ago by Martyn Gigg

Fix incorrect SIGNAL slot signature in SANS widgets. Refs #4940

Changeset: fcd79d5ba3e81ae1a0e3befbcd40fd441bbe00c9

comment:16 Changed 8 years ago by Martyn Gigg

  • Status changed from verify to verifying

comment:17 Changed 8 years ago by Martyn Gigg

  • Status changed from verifying to closed

After the signal/slot fix the interface ran the add procedure correctly and produced sensible output from the reduction.

comment:18 Changed 8 years ago by Martyn Gigg

Fix incorrect SIGNAL slot signature in SANS widgets. Refs #4940

Changeset: fcd79d5ba3e81ae1a0e3befbcd40fd441bbe00c9

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5786

Note: See TracTickets for help on using tickets.