Ticket #4942 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Remove uses of QVector::fromStdVector

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: minor Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

Because they cause a compiler warning in Visual Studio that we can't avoid because it's an inlined static function. Specifically it's because the QVector::reserve method takes an int and is passed a size_t coming out for std::vector::size within that function.

We could just turn the warning of at that point but it seems unnecessary to create the temporary QVector anyway.

Change History

comment:1 Changed 9 years ago by Russell Taylor

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Russell Taylor

Remove uses of QVector::fromStdVector. Re #4942.

Because they cause an MSVC compiler warning.

Changeset: 86e3100b2e485e4f45cd87b362d7daf7aafda583

comment:3 Changed 9 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 9 years ago by Russell Taylor

Remove uses of QVector::fromStdVector. Re #4942.

Because they cause an MSVC compiler warning.

Changeset: 86e3100b2e485e4f45cd87b362d7daf7aafda583

comment:5 Changed 8 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:6 Changed 8 years ago by Andrei Savici

  • Status changed from verifying to closed

No instance of fromStdVector found

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5788

Note: See TracTickets for help on using tickets.