CobaltSpinWaveDSHO function should not appear in the muon interface

[Robert Whitley]

To reproduce error,

1) Open MUSR00015193.nxs from the AutoTestData folder and plot it.

2) Using the FitPropertyBrowser try and fit a CobaltSpinWaveDSHO to the plotted data using the default values.

3) "Debug Error! - abort() has been called"

[Ronald Fowler]

Re #4999 added a category to CobaltSpinWave of "Inelastic"

Anders suggested the Inelastic category for these Tobyfit style functions to make clear they are not appropriate for other fit algorithms.

Changeset: 952162aa9d431b35df80ef1ed1e2cd096eaf3093

[Ronald Fowler]

This function now returns the above category, so should not be called by other methods, such as Muon. If it is called, it should return an error rather than call abort.

[Ronald Fowler]

Believe fixed by adding category as above.

[Michael Reuter]

Trying to fit a CobaltSpinWaveDHSO to Muon data.

[Michael Reuter]

When I try to fit this type of function to the muon data specified above I get a segmentation fault on RHEL6. I've attached a screenshot of the setup just before I apply the fit.

[Ronald Fowler]

The category "inelastic" for the three functions now available for use in instrument resolution simulation allows these to be made invisible to the user within the Muon analysis interface. However the "Fit Function" window still allows the user to try and fit these functions to any plot data. On windows 64 the error returned is "Unexpected domain in IFunctionMD", rather than the crash reported on RHEL6. Maybe the fit function window should also hide these functions unless it is used on an IMDWorkspace.

[Nick Draper]

Moved at the end of release 2.2

[Nick Draper]

Moved to release 2.4

[Nick Draper]

Moved at the code freeze for release 2.4

[Nick Draper]

Moved to r2.6 at the end of r2.5

[Arturs Bekasovs]

This ticket is rather outdated - we don't have CobaltSpinWaveDSHO any more.

However, we have another MD fit function - ResolutionConvolvedCrossSection accessible from Muon interface, so the problem remains.

Muon interface allows us to use fit functions from 3 categories only - "Muon", "General" and "Background". If we will move ResolutionConvolvedCrossSection and other MD fit functions to their own category, it will solve the problem.

[Arturs Bekasovs]

Added MD fit functions to separate category.

Refs #4999

Changeset: dcb022b27841a1205660452aa4befbba2780eae5

[Arturs Bekasovs]

Tester:

Just check that ResolutionConvolvedCrossSection appears in Quantification category with the regular fit browser (F4), and that we are unable to use it within the fit browser on the Data Analysis tab of the Muon Interface.

[Karl Palmen]

Branch expected but not found.

[Arturs Bekasovs]

Sorry, forgot to git finish. Should be OK now.

[Karl Palmen]

Unable to find ResolutionConvolvedCrossSection or its Quantification category. This may be just that I don't understant the GUI.

[Roman Tolchenov]

Merge remote-tracking branch 'origin/feature/4999_hide_md_functions_in_muon'

[Roman Tolchenov]

It works as described but I am not entirely sure that the Quantification functions should appear on FitBrowser either

[Stuart Campbell]

This ticket has been transferred to github issue ​5845