Ticket #4999 (closed: fixed)
CobaltSpinWaveDSHO function should not appear in the muon interface
Reported by: | Robert Whitley | Owned by: | Arturs Bekasovs |
---|---|---|---|
Priority: | major | Milestone: | Release 3.0 |
Component: | Muon | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Roman Tolchenov |
Description (last modified by Nick Draper) (diff)
To reproduce error,
1) Open MUSR00015193.nxs from the AutoTestData folder and plot it.
2) Using the FitPropertyBrowser try and fit a CobaltSpinWaveDSHO to the plotted data using the default values.
3) "Debug Error! - abort() has been called"
Attachments
Change History
comment:2 Changed 8 years ago by Ronald Fowler
- Status changed from new to accepted
This function now returns the above category, so should not be called by other methods, such as Muon. If it is called, it should return an error rather than call abort.
comment:3 Changed 8 years ago by Ronald Fowler
- Status changed from accepted to verify
- Resolution set to fixed
Believe fixed by adding category as above.
comment:4 Changed 8 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
Changed 8 years ago by Michael Reuter
- Attachment CSWDHSO_Issue.png added
Trying to fit a CobaltSpinWaveDHSO to Muon data.
comment:5 Changed 8 years ago by Michael Reuter
- Status changed from verifying to reopened
- Resolution fixed deleted
When I try to fit this type of function to the muon data specified above I get a segmentation fault on RHEL6. I've attached a screenshot of the setup just before I apply the fit.
comment:7 Changed 8 years ago by Ronald Fowler
The category "inelastic" for the three functions now available for use in instrument resolution simulation allows these to be made invisible to the user within the Muon analysis interface. However the "Fit Function" window still allows the user to try and fit these functions to any plot data. On windows 64 the error returned is "Unexpected domain in IFunctionMD", rather than the crash reported on RHEL6. Maybe the fit function window should also hide these functions unless it is used on an IMDWorkspace.
comment:8 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.2 to Release 2.3
Moved at the end of release 2.2
comment:9 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.3 to Release 2.4
Moved to release 2.4
comment:10 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.4 to Release 2.5
Moved at the code freeze for release 2.4
comment:11 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.5 to Release 2.6
comment:12 Changed 7 years ago by Nick Draper
- Owner changed from Ronald Fowler to Anyone
- Description modified (diff)
- Summary changed from Fix CobaltSpinWaveDSHO function. to CobaltSpinWaveDSHO function should not appear in the muon interface
comment:15 Changed 7 years ago by Nick Draper
- Owner changed from Anyone to Arturs Bekasovs
- Component changed from Framework to Muon
comment:18 Changed 7 years ago by Arturs Bekasovs
This ticket is rather outdated - we don't have CobaltSpinWaveDSHO any more.
However, we have another MD fit function - ResolutionConvolvedCrossSection accessible from Muon interface, so the problem remains.
Muon interface allows us to use fit functions from 3 categories only - "Muon", "General" and "Background". If we will move ResolutionConvolvedCrossSection and other MD fit functions to their own category, it will solve the problem.
comment:19 Changed 7 years ago by Arturs Bekasovs
Added MD fit functions to separate category.
Refs #4999
Changeset: dcb022b27841a1205660452aa4befbba2780eae5
comment:20 Changed 7 years ago by Arturs Bekasovs
Tester:
Just check that ResolutionConvolvedCrossSection appears in Quantification category with the regular fit browser (F4), and that we are unable to use it within the fit browser on the Data Analysis tab of the Muon Interface.
comment:21 Changed 7 years ago by Arturs Bekasovs
- Status changed from inprogress to verify
- Resolution set to fixed
comment:22 Changed 7 years ago by Karl Palmen
- Status changed from verify to verifying
- Tester changed from Michael Reuter to Karl Palmen
comment:23 Changed 7 years ago by Karl Palmen
- Status changed from verifying to verify
- Tester Karl Palmen deleted
Branch expected but not found.
comment:24 Changed 7 years ago by Arturs Bekasovs
Sorry, forgot to git finish. Should be OK now.
comment:25 Changed 7 years ago by Karl Palmen
- Status changed from verify to verifying
- Tester set to Karl Palmen
comment:26 Changed 7 years ago by Karl Palmen
- Status changed from verifying to verify
- Tester Karl Palmen deleted
Unable to find ResolutionConvolvedCrossSection or its Quantification category. This may be just that I don't understant the GUI.
comment:27 Changed 7 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
comment:28 Changed 7 years ago by Roman Tolchenov
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/4999_hide_md_functions_in_muon'
comment:29 Changed 7 years ago by Roman Tolchenov
It works as described but I am not entirely sure that the Quantification functions should appear on FitBrowser either
comment:30 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5845
Re #4999 added a category to CobaltSpinWave of "Inelastic"
Anders suggested the Inelastic category for these Tobyfit style functions to make clear they are not appropriate for other fit algorithms.