Ticket #5012 (reopened)

Opened 9 years ago

Last modified 5 years ago

[IDA] Elwin - Allow User to Specify Range of Files

Reported by: Peter Parker Owned by: Dan Nixon
Priority: major Milestone: Backlog
Component: Indirect Inelastic Keywords: IDA
Cc: Blocked By: #7515
Blocking: Tester:

Description (last modified by Samuel Jackson) (diff)

In the Energy Transfer tab of C2E, a user can specify a range of files to load by simply typing in the range, e.g. "2012-2020". The interface takes the currently selected instrument, analyser and reflection options, finds the appropriate file(s), and outputs the result with appropriate file names.

No such mechanism exists in IDA.

A possible way to implement this so that a range of files of the form [INST][RUN]_[ANALYSER][REFLECTION]_red.nxs could be loaded, would be the following:

  • Insist that the user inputs the range, as well as the instrument suffix (i.e. "IRS2012-2020" for the range of reduced Iris runs from 2012 to 2020).
  • Add functionality to FileFinder to accept a wild card[+] as well as the instrument / run number hint and file extensions.
  • Change the tabs so that they feed a wild card to FileFinder, placed between the range string and "_red.nxs".

[+] - The ability to accept any arbitrary string here, and not just a wildcard, would be useful elsewhere.

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:2 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:3 Changed 8 years ago by Peter Parker

  • Keywords IDA added

comment:4 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:5 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:6 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:7 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:8 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:9 Changed 7 years ago by Samuel Jackson

  • Owner changed from Peter Parker to Samuel Jackson
  • Description modified (diff)

comment:10 Changed 7 years ago by Samuel Jackson

  • Component changed from Framework to Indirect Inelastic

comment:11 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move to assigned at the introduction of the triage step

comment:12 Changed 6 years ago by Samuel Jackson

  • Status changed from assigned to inprogress

Refs #5012 Add support for range searching in FileFinder.

This includes a new public method called getFullPaths that takes a comma separated string for potential file paths attempts to find a match. If the file path contains something that looks like a range it will expand the range and look for each file in the range individually.

Changeset: cde229e43c78acfd9357e6036db55df3cd113fe2

comment:13 Changed 6 years ago by Samuel Jackson

Refs #5012 Move file finding logic to be contained in FindFiles.

This includes modifying the widget to use the getFullPaths function to find multiple file paths.

Changeset: 04fbaa38221dc9c73d00b82a7255557a1b65ec80

comment:14 Changed 6 years ago by Samuel Jackson

Refs #5012 Correct a seg fault with single file searching.

Changeset: 256658ca5062b8c2b2f45aae9c0f94b68a98f1e0

comment:15 Changed 6 years ago by Samuel Jackson

Refs #5012 Swap IDA interface to run LoadNexus C++ side.

This algorithm was being executed on a separate thread which was causing the automatic file searching to play up in certain cases where it would still be searching for files while the user had clicked the run button.

This change stops that from happening, but this should really be changed to use AlgorithmRunner. But that's outside the scope of this ticket.

Changeset: 5079b9b1bfd689d04b5a8cd2f1e8736b92ba7faf

comment:16 Changed 6 years ago by Samuel Jackson

Refs #5012 Export method to python api.

Changeset: 718cab70969cb6b95c25871e2259776e05d6063a

comment:17 Changed 6 years ago by Samuel Jackson

Refs #5012 Throw NotFoundError instead of invalid argument.

Changeset: 014638549299d0a0406b6552f671aa862d78f35c

comment:18 Changed 6 years ago by Samuel Jackson

Refs #5012 Add unit tests for new method.

Changeset: 89521499b5aea0100ba97e7c6e7d20fb23fbcd1e

comment:19 Changed 6 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Summary changed from [IDA] Elwin / MSDFit - Allow User to Specify Range of Files to [IDA] Elwin - Allow User to Specify Range of Files

To Tester

There is a new function on FileFinder (that is also exposed to python) called getFullPaths. This takes a comma separated list of string as hints that get passed to FileFinder.getFullPath.

e.g. FileFinder.getFullPaths("irs55127*, irs55128*, irs55129*")

This also accepts range hints. For example typing:

e.g. FileFinder.getFullPaths("irs55127:irs55129*")

Should produce the exact same output as the first example. Test that this works as you would expect.

Once you're sure this works, check that the file input widget on Elwin still works as before, but that you can now specify a range of runs using the same syntax as the examples above. For general instructions on running ElWin see:

http://www.mantidproject.org/Indirect:Indirect_Data_Analysis#Running_Elwin

comment:20 Changed 6 years ago by Samuel Jackson

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:21 Changed 6 years ago by Samuel Jackson

  • Milestone changed from Backlog to Release 3.3

comment:22 Changed 6 years ago by Samuel Jackson

  • Blocked By 7515 added

This ticket should hold off until we decide what is happening with #7515

comment:23 Changed 6 years ago by Samuel Jackson

  • Milestone changed from Release 3.3 to Release 3.4

comment:24 Changed 6 years ago by Samuel Jackson

  • Milestone changed from Release 3.4 to Backlog

comment:25 Changed 6 years ago by Nick Draper

  • Owner changed from Samuel Jackson to Dan Nixon

comment:26 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5858

Note: See TracTickets for help on using tickets.