Ticket #5043 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Mask returned from Instrument view is always the same

Reported by: Stuart Campbell Owned by: Stuart Campbell
Priority: major Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Karl Palmen

Description

It doesn't matter which option you choose (include/exclude) the resulting mask is always the same.

Change History

comment:1 Changed 9 years ago by Stuart Campbell

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Stuart Campbell

Clear the mask flag for output workspace. refs #5043

The SpecialWorkspace2D shouldn't have the masked flag set.

Changeset: 5241251ac9bd8736c5bac9f74997fd459431d570

comment:3 Changed 9 years ago by Stuart Campbell

Commented out test. refs #5043

I am not sure that this is the behaviour that we want, so I am commenting out this test for now.

Changeset: 6abc9c16fe194c021963fc37245c611afb12cde5

comment:4 Changed 9 years ago by Stuart Campbell

refs #5043 & #3700. Corrected to return mask and inverse.

Changed the confusing text labels on the GUI. Removed some of the logic code in the GUI code in favour of using existing algorithms.

Changeset: 6d4bcf8e8c3563b8482763ed788b9c68c1326e85

comment:5 Changed 8 years ago by Peter Peterson

Refs #5043. Extract mask wasn't copying the spectradetector map.

Changeset: 0c1a2db4576f9aabfc186c9ce4a425169b29569f

comment:6 Changed 8 years ago by Peter Peterson

Refs #5043. LoadMask returns a MaskWorkspace.

Changeset: a35a3a5f08314260471b7545586df8c16e87a671

comment:7 Changed 8 years ago by Peter Peterson

Refs #5043. Extract mask wasn't copying the spectradetector map.

Changeset: 0c1a2db4576f9aabfc186c9ce4a425169b29569f

comment:8 Changed 8 years ago by Peter Peterson

Refs #5043. LoadMask returns a MaskWorkspace.

Changeset: a35a3a5f08314260471b7545586df8c16e87a671

comment:9 Changed 8 years ago by Stuart Campbell

  • Status changed from accepted to verify
  • Resolution set to fixed

To Test:

  1. Load any dataset and view the instrument.
  2. On the Mask tab, draw a mask, then apply it.
  3. Extract the mask to a workspace, then rename it.
  4. Extract the inverted mask to a workspace.
  5. Look at both of these workspaces in the instrument view - one should be the inverse of the other.

comment:10 Changed 8 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:11 Changed 8 years ago by Karl Palmen

  • Status changed from verifying to closed

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5889

Note: See TracTickets for help on using tickets.