Ticket #5070 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Investigate new polygon rebinning algorithm

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: major Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description (last modified by Michael Reuter) (diff)

A new polygon rebinning algorithm (SofQW3) will be created to handle PSD type instruments. Work will also be done to check compatibility with non-PSD instruments. This will be non-production code until tested everywhere and under as many situations as possible.

Change History

comment:1 Changed 9 years ago by Michael Reuter

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Michael Reuter

  • Description modified (diff)

comment:3 Changed 8 years ago by Michael Reuter

Refs #5070. Initial work on new algorithm.

Changeset: e36d0a3c58ba0f9c02e71e58437ade9fcf5357b2

comment:4 Changed 8 years ago by Michael Reuter

Refs #5070. Missed file and changes.

Changeset: aaa5c368f04979eb18b5d857f32fa087c0e00ea5

comment:5 Changed 8 years ago by Michael Reuter

Refs #5070. New workspace, same as the old workspace.

Changeset: 52eda886699b422155a638d37c4bd27f4f8dc3e1

comment:6 Changed 8 years ago by Michael Reuter

Refs #5069 and #5070. Updates to workspace and algorithm.

The rebinning workspace now has the fractional area tracking. This has been propogated to the necessary places in the algorithm for handling.

Changeset: 69407694d84f8682ba9aa26950d317a816e0bb47

comment:7 Changed 8 years ago by Michael Reuter

Refs #5069 and #5070. Updates to workspace and algorithm.

The rebinning workspace now has the fractional area tracking. This has been propogated to the necessary places in the algorithm for handling.

Changeset: 69407694d84f8682ba9aa26950d317a816e0bb47

comment:8 Changed 8 years ago by Michael Reuter

Refs #5070. Fixes to get fractional area to actually be used.

Changeset: e42bf683494fddde871480c9ad97fc1adc9081a8

comment:9 Changed 8 years ago by Michael Reuter

Refs #5070. Fixes to get fractional area to actually be used.

Changeset: e42bf683494fddde871480c9ad97fc1adc9081a8

comment:10 Changed 8 years ago by Michael Reuter

Refs #5070. Trying to handle non-PSD and PSD instruments.

Changeset: 1bf9ba2e0af56e361ba16c718bd08c9429eef128

comment:11 Changed 8 years ago by Michael Reuter

Refs #5070. Adding wiki docs.

Changeset: 5c6f50bf50677c3e2fc1317662d3ffb87ac41603

comment:12 Changed 8 years ago by Michael Reuter

Refs #5070. Making new algorithm an option on CTE.

Changeset: 6843467bbbd873275192cde3059af29fbe78040a

comment:13 Changed 8 years ago by Michael Reuter

Refs #5070. Lowering log levels.

Changeset: 30413f0dfe11369d4ac27feb64d1421b670466b6

comment:14 Changed 8 years ago by Michael Reuter

Refs #5070. Trying to handle non-PSD and PSD instruments.

Changeset: 1bf9ba2e0af56e361ba16c718bd08c9429eef128

comment:15 Changed 8 years ago by Michael Reuter

Refs #5070. Adding wiki docs.

Changeset: 5c6f50bf50677c3e2fc1317662d3ffb87ac41603

comment:16 Changed 8 years ago by Michael Reuter

Refs #5070. Making new algorithm an option on CTE.

Changeset: 6843467bbbd873275192cde3059af29fbe78040a

comment:17 Changed 8 years ago by Michael Reuter

Refs #5070. Lowering log levels.

Changeset: 30413f0dfe11369d4ac27feb64d1421b670466b6

comment:18 Changed 8 years ago by Michael Reuter

  • Status changed from accepted to verify
  • Resolution set to fixed

I'm not sure there is an easy way to test this. The new algorithm is available for testing from the Convert to Energy GUI for indirect instruments. It can be run for direct instruments via the algorithm selector box after running the CTE.

comment:19 Changed 8 years ago by Michael Reuter

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:20 Changed 8 years ago by Michael Reuter

  • Status changed from reopened to accepted

comment:21 Changed 8 years ago by Michael Reuter

  • Status changed from accepted to verify
  • Resolution set to fixed

Jon Taylor thinks that this algorithm is doing the right thing.

comment:22 Changed 8 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:23 Changed 8 years ago by Martyn Gigg

  • Status changed from verifying to closed

Jon has had a look after the last few changes and is happy that both the values and errors are doing the right thing.

comment:24 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5916

Note: See TracTickets for help on using tickets.