Ticket #5174 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Why does MemoryManager test for memory less than set amount?

Reported by: Martyn Gigg Owned by: Russell Taylor
Priority: minor Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description

In response to #4874. Is the MemoryManager test regarding total available memory valid? I think not...

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:2 Changed 8 years ago by Nick Draper

  • Owner set to Russell Taylor
  • Status changed from new to assigned

comment:3 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

http://www.mantidproject.org/Release_Notes_2_2_Full_List

comment:4 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to release 2.4

comment:5 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:6 Changed 8 years ago by Russell Taylor

Re #5174. Up memory limit tested against and add message to test.

I think this test still has some value in partly checking complete nonsense isn't going into the variable. So I've increased the RAM tested against to a value that isn't likely to be encountered in the foreseeable future and added a failure message so that it's clear what is being tested against.

Changeset: b9309228e2cd6fec6a74ebf1986d925b813c0372

comment:7 Changed 8 years ago by Russell Taylor

  • Status changed from assigned to closed
  • Resolution set to fixed

To test: Just look at the 1 line I changed and agree that I did the right thing!

comment:8 Changed 8 years ago by Russell Taylor

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:9 Changed 8 years ago by Russell Taylor

  • Status changed from reopened to accepted

comment:10 Changed 8 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

Trying closure again. See comment:7 for testing.

comment:11 Changed 8 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:12 Changed 8 years ago by Nick Draper

  • Status changed from verifying to closed

Max limit set to 1,000,000GB. This should be safe for a while.

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6020

Note: See TracTickets for help on using tickets.