Ticket #5240 (closed: worksforme)

Opened 8 years ago

Last modified 5 years ago

ConvertToMDEvents displays progress incorrectly

Reported by: Alex Buts Owned by: Alex Buts
Priority: major Milestone: Release 2.3
Component: VATES Keywords:
Cc: Blocked By:
Blocking: Tester: Dereck Kachere

Description

Converting workspace into MD workspace is done in two steps where the first step usually deals with the conversion of whatever is in input workspace into the output data and the second -- converting these data into MDevents and adding this to MDEventWorkspace.

The second step can take considerable time in comparison with the first step, but the algorithm progress is estimated on the basis of doing the first step only.

Progress bar in this case goes from start to 99% and then freezes at the end for considerable amount of time.

Annoying.

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Alex Buts

comment:2 Changed 8 years ago by Alex Buts

refs #5240 MDBoxToChange.h class is more or less functional

also relates to refs #5552

Changeset: 6291ea48ce4532232bcff7484f966b5da74e929d

comment:3 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:4 Changed 8 years ago by Alex Buts

refs #5240 MDBoxToChange.h class is more or less functional

also relates to refs #5552

Changeset: 6291ea48ce4532232bcff7484f966b5da74e929d

comment:5 Changed 8 years ago by Alex Buts

  • Status changed from assigned to accepted

this ticket depends on #5552 and reasonably (though not ideally) works with current multi-threading implementation.

I think the implementation is satisfactory and all other changes are subject to changes described in #5552.

To testers: run the conversion (preferably on large and unexpected files, I did real MERLIN and MAPS runs) and see if the progress bar you see allows you to reasonably estimate the real progress.

comment:6 Changed 8 years ago by Alex Buts

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:7 Changed 8 years ago by Alex Buts

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:8 Changed 8 years ago by Alex Buts

  • Status changed from reopened to accepted

comment:9 Changed 8 years ago by Alex Buts

  • Status changed from accepted to verify
  • Resolution set to worksforme

comment:10 Changed 8 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:11 Changed 8 years ago by Karl Palmen

  • Status changed from verifying to verify
  • Tester Karl Palmen deleted

comment:12 Changed 8 years ago by Dereck Kachere

  • Status changed from verify to verifying
  • Tester set to Dereck Kachere

comment:13 Changed 8 years ago by Dereck Kachere

  • Status changed from verifying to closed

Progress bar no longer goes from start to 99% and then freeze; the progress bar updates in stages and gives a reasonable time estimate for completion.

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 6086

Note: See TracTickets for help on using tickets.