Ticket #5244 (closed: fixed)
Add To MD workspace can be too slow on Windows
| Reported by: | Alex Buts | Owned by: | Alex Buts |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.2 |
| Component: | VATES | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Martyn Gigg |
Description
when one works with ConvertToMDEvent workspace, it is usual to play with box controller parameters to obtain best image possible.
Doing so, it is easy to go into mode, when the binned image exceeds the memory available.
When it exceeds it too much, all fine and algorithm does not work. The problem occurs when the size of the image is close to the size of the memory. Widows start swapping, system freezes and you sitting in front of non-responding screen for ages. It should be a possibility to warn user about such situation.
The ticket is closely connected (and may be a duplicate) of #5240
Change History
comment:1 Changed 8 years ago by Nick Draper
- Owner set to Alex Buts
- Status changed from new to assigned
comment:3 Changed 8 years ago by Alex Buts
refs #5244 further modifications to allow ConvToMD running multithread
refs #5537 Renamed couple of classes responsible for event conversion
Changeset: 172f07be616d985451f3fe9ed47d878112e47bd7
comment:4 Changed 8 years ago by Alex Buts
refs #5244 fixed bug with unit conversion constructor
Changeset: 9765da3fdb85def9f0dec62a078f80949de26648
comment:5 Changed 8 years ago by Alex Buts
refs #5244 fixed error with new ConvToMDEventsWS version
Changeset: 32911ebcfe38b01278e34bfa9da508de4de9f807
comment:6 Changed 8 years ago by Alex Buts
refs #5244 Test modified to check runNum and DetId
Changeset: 829d5e24976179ebb22f89886fdf456ee417de24
comment:7 Changed 8 years ago by Alex Buts
refs #5244 Tread pool enabled for splitting workspaces
both for Matrix and for Event workspaces
Changeset: 1e789ce1fedbe9f78332b036e0dd05e6128609cc
comment:8 Changed 8 years ago by Alex Buts
refs #5244 This mainly fixes it
according to Janik recommendations. Unfortunately, it does not work as expected and number of other have been generated
Changeset: c57d803e0dbf633e1b74a62f4028a80a758339e6
comment:9 Changed 8 years ago by Alex Buts
refs #5244 minor additions to resolution
Changeset: 782bba3b8c18cbc302a336695ccb62629d5604be
comment:10 Changed 8 years ago by Alex Buts
refs #5244 fixing unix warnings
Changeset: 76564b6d63ed997f29fac880e3b050cb80307143
comment:11 Changed 8 years ago by Alex Buts
- Status changed from accepted to verify
- Resolution set to fixed
This takes too long to resolve as the path, suggested by Janik is not fully works. I am closing this ticket for the time being but two other tickets (bug and extension) are still left to deal with.
comment:12 Changed 8 years ago by Alex Buts
refs #5244 further modifications to allow ConvToMD running multithread
refs #5537 Renamed couple of classes responsible for event conversion
Changeset: 172f07be616d985451f3fe9ed47d878112e47bd7
comment:13 Changed 8 years ago by Alex Buts
refs #5244 fixed bug with unit conversion constructor
Changeset: 9765da3fdb85def9f0dec62a078f80949de26648
comment:14 Changed 8 years ago by Alex Buts
refs #5244 fixed error with new ConvToMDEventsWS version
Changeset: 32911ebcfe38b01278e34bfa9da508de4de9f807
comment:15 Changed 8 years ago by Alex Buts
refs #5244 Test modified to check runNum and DetId
Changeset: 829d5e24976179ebb22f89886fdf456ee417de24
comment:16 Changed 8 years ago by Alex Buts
refs #5244 Tread pool enabled for splitting workspaces
both for Matrix and for Event workspaces
Changeset: 1e789ce1fedbe9f78332b036e0dd05e6128609cc
comment:17 Changed 8 years ago by Alex Buts
refs #5244 This mainly fixes it
according to Janik recommendations. Unfortunately, it does not work as expected and number of other have been generated
Changeset: c57d803e0dbf633e1b74a62f4028a80a758339e6
comment:18 Changed 8 years ago by Alex Buts
refs #5244 minor additions to resolution
Changeset: 782bba3b8c18cbc302a336695ccb62629d5604be
comment:19 Changed 8 years ago by Alex Buts
refs #5244 fixing unix warnings
Changeset: 76564b6d63ed997f29fac880e3b050cb80307143
comment:20 Changed 8 years ago by Alex Buts
This is still too slow, though convertToMD runs adding multithreaded. this ticket relates to number of other open tickets
The resolution can check if adding to MDWorkspace runs multi-threaded and the results are correct.
comment:21 Changed 8 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:22 Changed 8 years ago by Martyn Gigg
- Status changed from verifying to closed
It looks as if it is running multi-threaded but it would seem that there is more work to do but it does work. See #5552
comment:23 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6090
