Ticket #5272 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Small Python console glitch.

Reported by: Peter Parker Owned by: Nick Draper
Priority: trivial Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Harry Jeffery

Description (last modified by Dan Nixon) (diff)

Very minor ticket, but this is something I run into often while making small adjustments to scripts and testing them as I go. To reproduce:

  1. Open up your favourite script in a MantidPlot Python Window.
  2. Pressing Ctrl+Return will obviously execute the script.
  3. Now, highlight some part of the script and press some alphanumeric keys.
  4. Pressing Ctrl+Return immediately after making the edit now has no effect. The user must move the cursor, or go to "Execute"->"Execute Selection".

Nothing major at all, just a small usability point.

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Owner set to Anyone
  • Status changed from new to assigned

comment:2 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

comment:3 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to release 2.4

comment:4 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:5 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:6 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:7 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:8 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to the Backlog after the code freeze for R2.6

comment:9 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

bulk move to assigned at the into of the triage step

comment:10 Changed 6 years ago by Dan Nixon

  • Owner changed from Anyone to Dan Nixon
  • Status changed from assigned to verify
  • Resolution set to worksforme
  • Description modified (diff)

Cannot reporduce the original issue.

comment:11 Changed 6 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:12 Changed 6 years ago by Peter Parker

I've tried this again in a Windows nightly build from 18 Nov, which is the most recent version I have installed. It is *still* an issue in that version. Perhaps it's been fixed since then but I don't think it's likely.

To clarify:

  • Open up the script window.
  • Type print "test"
  • Hit Ctrl+Return to print "test" to the screen.
  • Highlight the word "test" and type another test that will not work.
  • Pressing Ctrl + Return will not work until you move the cursor again.

Those instructions have to be followed *exactly*. Maybe it's only a problem on Windows.

comment:13 Changed 6 years ago by Nick Draper

I agree I was just writing this:

This is actually a bug, albeit a very minor one

Steps to reproduce:

  1. put this in the script window
    print "hi"
    print 2+1
    print "bob"
    
  2. With the cursor at the end hit ctrl and enter - it will run (if there is no selection Mantid is supposed to run everything)

Highlight and replace the middle line with a so the script looks like

print "hi"
a
print "bob"
  1. before you click anywhere else hit ctrl+enter - nothing happens, but it should

comment:14 Changed 6 years ago by Nick Draper

  • Status changed from verifying to reopened
  • Resolution worksforme deleted

comment:15 Changed 6 years ago by Nick Draper

  • Owner changed from Dan Nixon to Nick Draper

comment:16 Changed 6 years ago by Nick Draper

  • Status changed from reopened to inprogress
  • Milestone changed from Backlog to Release 3.3

comment:17 Changed 6 years ago by Nick Draper

Found it!

comment:18 Changed 6 years ago by Nick Draper

re #5272 Fix for script edit bug

Changeset: 265fc135dbb10d0e05b0ad9ff8379473aa24cb45

comment:19 Changed 6 years ago by Nick Draper

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Test

see comments 12 and 13 for steps to reproduce

comment:20 Changed 6 years ago by Peter Parker

This one still needs a quick checkbuild, Nick.

comment:21 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester changed from Nick Draper to Harry Jeffery

comment:22 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/5272_scripteditor_wont_exec_after_selection_edit'

Full changeset: f597473a00a08373cc42385b136c4ff43e10a6f3

comment:23 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 6118

Note: See TracTickets for help on using tickets.