Ticket #5414 (closed: fixed)
Support Tube Calibration by Python Scripts
| Reported by: | Karl Palmen | Owned by: | Karl Palmen |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.3 |
| Component: | Mantid | Keywords: | |
| Cc: | anders.markvardsen@… | Blocked By: | |
| Blocking: | Tester: | Anders Markvardsen |
Description
This includes adding an algorithm ApplyCalibration to move detectors according to the calibration. Also a class may be added to handle the specification of a set of tubes.
Change History
comment:1 Changed 8 years ago by Karl Palmen
- Owner set to Karl Palmen
- Status changed from new to accepted
comment:2 Changed 8 years ago by Karl Palmen
First go at ApplyCalibration untested re #5414
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: ce80a4260ed66035480e93958ff72cff3ad29251
comment:3 Changed 8 years ago by Karl Palmen
Add python algorithm to create table workspace re #5414
Changeset: 89481f847b26d41182c75919f86764eb4e4120d1
comment:4 Changed 8 years ago by Karl Palmen
Code now working re #5414
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 61e4a9151d76a81cc2bf76772d74905851c37afc
comment:5 Changed 8 years ago by Karl Palmen
First go at ApplyCalibration untested re #5414
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: ce80a4260ed66035480e93958ff72cff3ad29251
comment:6 Changed 8 years ago by Karl Palmen
Add python algorithm to create table workspace re #5414
Changeset: 89481f847b26d41182c75919f86764eb4e4120d1
comment:7 Changed 8 years ago by Karl Palmen
Code now working re #5414
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 61e4a9151d76a81cc2bf76772d74905851c37afc
comment:8 Changed 8 years ago by Karl Palmen
First go at ApplyCalibration untested re #5414
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: ce80a4260ed66035480e93958ff72cff3ad29251
comment:9 Changed 8 years ago by Karl Palmen
Add python algorithm to create table workspace re #5414
Changeset: 89481f847b26d41182c75919f86764eb4e4120d1
comment:10 Changed 8 years ago by Karl Palmen
Code now working re #5414
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 61e4a9151d76a81cc2bf76772d74905851c37afc
comment:11 Changed 8 years ago by Russell Taylor
Re #5414. Clear compiler warnings.
Changeset: efb00c26253ae140cf28e3fdd7518e8a7e2bb2ce
comment:12 Changed 8 years ago by Russell Taylor
Re #5414. Clear compiler warnings.
Changeset: efb00c26253ae140cf28e3fdd7518e8a7e2bb2ce
comment:13 Changed 8 years ago by Russell Taylor
Re #5414. Clear compiler warnings.
Changeset: efb00c26253ae140cf28e3fdd7518e8a7e2bb2ce
comment:14 Changed 8 years ago by Russell Taylor
Re #5414. Clear compiler warnings.
Changeset: efb00c26253ae140cf28e3fdd7518e8a7e2bb2ce
comment:15 Changed 8 years ago by Karl Palmen
Before this ticket can be closed we need a unit test for the ApplyCaibration algorithm and the python algorithm to create a table workspace for calibration.
An example of a python unit test is found at https://github.com/mantidproject/mantid/blob/master/Code/Mantid/Framework/PythonInterface/test/python/CreateWorkspaceTest.py
comment:16 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.2 to Release 2.3
Moved at the end of release 2.2
comment:17 Changed 8 years ago by Karl Palmen
Add new python code re #5414
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 22e45fdf07ca0f857fcade69a1071f9ba3734a04
comment:18 Changed 8 years ago by Karl Palmen
Delete Temporary Workspaces used for Calibration re #5414
More work is needed on this because it deletes after each tube calibration so slowing down the calibration.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 5dfd1417a132ca95bc20f6acb9981aefa91360ea
comment:19 Changed 8 years ago by Karl Palmen
Complete work on deleting unwanted workspaces at end re #5414
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: a09ed7439910302665c49fb7430f2ba301e3daa7
comment:20 Changed 8 years ago by Karl Palmen
Further improvements for re #5414
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 578c509dc5389d7d7c9960fd029280fa41d6bda9
comment:21 Changed 8 years ago by Karl Palmen
Prepare for release re #5414
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: d6c1948785559e3ebb96ad82ef1488559642b863
comment:22 Changed 8 years ago by Karl Palmen
Final (hopefully) Changes for Release re #5414
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: db5659d62e7629081e03a9c3f21089eb40e55164
comment:23 Changed 8 years ago by Karl Palmen
- Status changed from accepted to verify
- Resolution set to fixed
comment:24 Changed 8 years ago by Anders Markvardsen
- Status changed from verify to verifying
- Tester set to Anders Markvardsen
comment:25 Changed 8 years ago by Karl Palmen
Show full path of peaks file re #5414
Also had this file name defined in only one place (rather than two changed to three).
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 02ca5612565c8be3be65cf602c413265113a8595
comment:26 Changed 8 years ago by Karl Palmen
Improve file name messages re #5414
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 88e11fea03aee3f288a998631c0472b1434807a7
comment:27 Changed 8 years ago by Anders Markvardsen
- Status changed from verifying to closed
Uumm I thought I just closed this one....
OK, hope I have not closed a wrong one.
For this ticket, now finished testing and script has been completed including adding Rob's suggestions
comment:28 Changed 8 years ago by Karl Palmen
Add new python code re #5414
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 22e45fdf07ca0f857fcade69a1071f9ba3734a04
comment:29 Changed 8 years ago by Karl Palmen
Delete Temporary Workspaces used for Calibration re #5414
More work is needed on this because it deletes after each tube calibration so slowing down the calibration.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 5dfd1417a132ca95bc20f6acb9981aefa91360ea
comment:30 Changed 8 years ago by Karl Palmen
Complete work on deleting unwanted workspaces at end re #5414
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: a09ed7439910302665c49fb7430f2ba301e3daa7
comment:31 Changed 8 years ago by Karl Palmen
Further improvements for re #5414
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 578c509dc5389d7d7c9960fd029280fa41d6bda9
comment:32 Changed 8 years ago by Karl Palmen
Prepare for release re #5414
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: d6c1948785559e3ebb96ad82ef1488559642b863
comment:33 Changed 8 years ago by Karl Palmen
Final (hopefully) Changes for Release re #5414
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: db5659d62e7629081e03a9c3f21089eb40e55164
comment:34 Changed 8 years ago by Karl Palmen
Show full path of peaks file re #5414
Also had this file name defined in only one place (rather than two changed to three).
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 02ca5612565c8be3be65cf602c413265113a8595
comment:35 Changed 8 years ago by Karl Palmen
Improve file name messages re #5414
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 88e11fea03aee3f288a998631c0472b1434807a7
comment:36 Changed 8 years ago by Karl Palmen
Final (hopefully) Changes for Release re #5414
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: db5659d62e7629081e03a9c3f21089eb40e55164
comment:37 Changed 8 years ago by Karl Palmen
Show full path of peaks file re #5414
Also had this file name defined in only one place (rather than two changed to three).
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 02ca5612565c8be3be65cf602c413265113a8595
comment:38 Changed 8 years ago by Karl Palmen
Improve file name messages re #5414
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 88e11fea03aee3f288a998631c0472b1434807a7
comment:39 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6260
