Ticket #5417 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

DAE Miscommunication

Reported by: Owen Arnold Owned by: Roman Tolchenov
Priority: critical Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

Problems reported from instrument scientists "Load Workspace from DAE" for DAE Name = NDXPOLREF, Workspace Name = dae

Doesn't seem to load the data properly. More details available in email from T. Charlton.

Attachments

ndlpolref1.isis.cclrc.ac.uk.jpg​ (104.1 KB) - added by Roman Tolchenov 7 years ago.
ticket_5417.png​ (81.9 KB) - added by Gesner Passos 7 years ago.
The way I've tested

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:2 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:3 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:4 Changed 8 years ago by Roman Tolchenov

Fix for loading multiperiod data. Re #5417.

Changeset: 61d2e3c540492bcddf333637d2483cbe141e4723

comment:5 Changed 8 years ago by Roman Tolchenov

  • Status changed from new to accepted

comment:6 Changed 7 years ago by Roman Tolchenov

Fix for loading multiperiod data. Re #5417.

Changeset: 61d2e3c540492bcddf333637d2483cbe141e4723

comment:7 Changed 7 years ago by Roman Tolchenov

To tester:

The email looked like this:

Has StartLiveData been tested with multiple periods? See attached issue highlighted in green.

-Tim

Changed 7 years ago by Roman Tolchenov

comment:8 Changed 7 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:9 Changed 7 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

Changed 7 years ago by Gesner Passos

The way I've tested

comment:10 Changed 7 years ago by Gesner Passos

  • Status changed from verifying to reopened
  • Resolution fixed deleted

I've added the screen shot showing the way I've tested. I'm still seing the Anonymous workspace ​http://trac.mantidproject.org/mantid/attachment/ticket/5417/ticket_5417.png.

comment:11 Changed 7 years ago by Roman Tolchenov

Remove Anonymous workspace from ADS added by LoadInstrument. Re #5417.

Changeset: c146944ff4aceedc1ab0484a523fae07dc511a9a

comment:12 Changed 7 years ago by Roman Tolchenov

Remove Anonymous workspace from ADS added by LoadInstrument. Re #5417.

Changeset: c146944ff4aceedc1ab0484a523fae07dc511a9a

comment:13 Changed 7 years ago by Roman Tolchenov

  • Status changed from reopened to accepted

comment:14 Changed 7 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:15 Changed 7 years ago by Russell Taylor

  • Status changed from verify to reopened
  • Resolution fixed deleted

This last commit is too much of a hack. The proper fix is to make sure the "Anonymous" workspace does not get in there in the first place. Take a look at the code running LoadInstrument in the SNSLiveEventDataListener - we don't have problems with any workspace appearing there (though I have to admit I don't immediately know why there's different behaviour).

If there's ever the effort available, it seems there's work to be done around ensuring consistent behaviour for child algorithms and not having to use a workaround to avoid complaints about missing workspace names.

comment:16 Changed 7 years ago by Russell Taylor

  • type changed from enhancement to defect
  • Tester Gesner Passos deleted

comment:17 Changed 7 years ago by Roman Tolchenov

  • Status changed from reopened to accepted

comment:18 Changed 7 years ago by Roman Tolchenov

Running the child algorithm properly now. Re #5417.

Changeset: b00af84d4b5c4762dc10ad9a0175f158603560ef

comment:19 Changed 7 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:20 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:21 Changed 7 years ago by Roman Tolchenov

Fix for loading multiperiod data. Re #5417.

Changeset: 61d2e3c540492bcddf333637d2483cbe141e4723

comment:22 Changed 7 years ago by Roman Tolchenov

Remove Anonymous workspace from ADS added by LoadInstrument. Re #5417.

Changeset: c146944ff4aceedc1ab0484a523fae07dc511a9a

comment:23 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

Checked that the anonymous workspace fix is not the proper one.

Tested both StartLiveData & LoadDAE and both give much more sensible results.

comment:24 Changed 7 years ago by Roman Tolchenov

Fix for loading multiperiod data. Re #5417.

Changeset: 61d2e3c540492bcddf333637d2483cbe141e4723

comment:25 Changed 7 years ago by Roman Tolchenov

Remove Anonymous workspace from ADS added by LoadInstrument. Re #5417.

Changeset: c146944ff4aceedc1ab0484a523fae07dc511a9a

comment:26 Changed 7 years ago by Roman Tolchenov

Fix for loading multiperiod data. Re #5417.

Changeset: 61d2e3c540492bcddf333637d2483cbe141e4723

comment:27 Changed 7 years ago by Roman Tolchenov

Remove Anonymous workspace from ADS added by LoadInstrument. Re #5417.

Changeset: c146944ff4aceedc1ab0484a523fae07dc511a9a

comment:28 Changed 7 years ago by Roman Tolchenov

Running the child algorithm properly now. Re #5417.

Changeset: b00af84d4b5c4762dc10ad9a0175f158603560ef

comment:29 Changed 7 years ago by Roman Tolchenov

Running the child algorithm properly now. Re #5417.

Changeset: b00af84d4b5c4762dc10ad9a0175f158603560ef

comment:30 Changed 7 years ago by Roman Tolchenov

Running the child algorithm properly now. Re #5417.

Changeset: b00af84d4b5c4762dc10ad9a0175f158603560ef

comment:31 Changed 7 years ago by Roman Tolchenov

Fix for loading multiperiod data. Re #5417.

Changeset: 61d2e3c540492bcddf333637d2483cbe141e4723

comment:32 Changed 7 years ago by Roman Tolchenov

Remove Anonymous workspace from ADS added by LoadInstrument. Re #5417.

Changeset: c146944ff4aceedc1ab0484a523fae07dc511a9a

comment:33 Changed 7 years ago by Roman Tolchenov

Running the child algorithm properly now. Re #5417.

Changeset: b00af84d4b5c4762dc10ad9a0175f158603560ef

comment:34 Changed 7 years ago by Roman Tolchenov

Running the child algorithm properly now. Re #5417.

Changeset: b00af84d4b5c4762dc10ad9a0175f158603560ef

comment:35 Changed 7 years ago by Roman Tolchenov

Fix for loading multiperiod data. Re #5417.

Changeset: 61d2e3c540492bcddf333637d2483cbe141e4723

comment:36 Changed 7 years ago by Roman Tolchenov

Remove Anonymous workspace from ADS added by LoadInstrument. Re #5417.

Changeset: c146944ff4aceedc1ab0484a523fae07dc511a9a

comment:37 Changed 7 years ago by Roman Tolchenov

Merge branch 'feature/5417_dae_miscommunication' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:38 Changed 7 years ago by Roman Tolchenov

Merge branch 'feature/5417_dae_miscommunication' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:39 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6263

Note: See TracTickets for help on using tickets.