Ticket #5484 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

QueryMDWorkspace normalisation fixes

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By: #5701
Blocking: Tester: Michael Reuter

Description

As reported by a user during this iteration. The algorithm is reporting Signal and Error values, that are actually normalised by volume.

Here are the proposed changes:

  • Add a Normalisation property to the QueryMDWorkspace algorithm
  • Default the Normalisation property to none
  • Ensure that the 'List Data' right-click option on the MDWokspace uses the 'none' normalisation option.

Change History

comment:1 Changed 8 years ago by Owen Arnold

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Owen Arnold

refs #5484. Works with normalisation option.

Changeset: 423544e43ca427d2c8f71bcc8c99f009f91666dc

comment:3 Changed 8 years ago by Owen Arnold

refs #5484. Works with normalisation option.

Changeset: 423544e43ca427d2c8f71bcc8c99f009f91666dc

comment:4 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester: You should be able to use the additional Normalisation option on QueryMDWorkspace now. The labels in the output table workspace, should indicate how the normalisation has occurred.

Here's an example of normalising by volume:

CreateMDHistoWorkspace(SignalInput='1,2,3,4,5',ErrorInput='1,1,1,1,1',Dimensionality='1',Extents='-1,1',NumberOfBins='5',Names='A',Units='U',OutputWorkspace='demo') QueryMDWorkspace(InputWorkspace='demo',OutputWorkspace='query',MaximumRows='500',Normalisation='volume')

comment:5 Changed 8 years ago by Owen Arnold

refs #5541 #5548 #5484. Fix warnings

Changeset: 0705d180a77fbf5436b2480550399e5017862e6e

comment:6 Changed 8 years ago by Owen Arnold

refs #5484. Works with normalisation option.

Changeset: 423544e43ca427d2c8f71bcc8c99f009f91666dc

comment:7 Changed 8 years ago by Owen Arnold

refs #5541 #5548 #5484. Fix warnings

Changeset: 0705d180a77fbf5436b2480550399e5017862e6e

comment:8 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:9 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to reopened
  • Resolution fixed deleted

I'm getting a strange error when I run the above lines. It seems to be generated by QueryMDWorkspace in python. I can run the CreateMDHistoWorkspace call in MantidPlot and then I do the query call from the script interpreter. 

KeyError: "'' does not exist."
  at line 1 in '__main__'
  caused by line 454 in '/home/2zr/build/Mantid-release/bin/mantid/simpleapi.py'
  caused by line 389 in '/home/2zr/build/Mantid-release/bin/mantid/simpleapi.py'

comment:10 Changed 8 years ago by Owen Arnold

  • Status changed from reopened to accepted

Yes, I can reproduce this error too, but only via the Python API.

comment:11 Changed 8 years ago by Owen Arnold

  • Blocked By 5701 added

comment:12 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

This was actually a python error. And has been fixed in #5701 this morning. Should work on the latest incremental builds.

comment:13 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying

comment:14 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to closed

It works without error now.

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6330

Note: See TracTickets for help on using tickets.