Ticket #5548 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

LoadISISNexus does not process Periods

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: blocker Milestone: Release 2.2
Component: Mantid Keywords:
Cc: nick.draper@… Blocked By:
Blocking: Tester: Martyn Gigg

Description

The ISIS nexus loader hard-codes a single period log entry for each workspace-period. It is therefore not possible to apply any filtering on log values on multiperiod data loaded via this format.

To reproduce, load a multi-period isis nexus file and try to run something like the following:

# ws = the second workspace in the group corresponding to period 2.

run = ws.getRun()

period_log =run.getLogData('period 2')

see the LoadLogs method in LoadISISNexus2.cpp, since the period is not provided, it uses the default argument of 1.

Change History

comment:1 Changed 8 years ago by Owen Arnold

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Owen Arnold

refs #5548. Should handle periods now.

Changeset: 6848f3850772f9b0580d2f237a4b82128a8c4c3f

comment:3 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester: Use the script example in the ticket description to verify this is working, also see the new Unit tests.

Note that providing full and correct information in the period properties is the subject of ticket #5546

comment:4 Changed 8 years ago by Owen Arnold

refs #5541 #5548 #5484. Fix warnings

Changeset: 0705d180a77fbf5436b2480550399e5017862e6e

comment:5 Changed 8 years ago by Owen Arnold

refs #5548. Should handle periods now.

Changeset: 6848f3850772f9b0580d2f237a4b82128a8c4c3f

comment:6 Changed 8 years ago by Owen Arnold

refs #5541 #5548 #5484. Fix warnings

Changeset: 0705d180a77fbf5436b2480550399e5017862e6e

comment:7 Changed 8 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:8 Changed 8 years ago by Martyn Gigg

  • Status changed from verifying to closed

Confirmed that the period logs are now created correctly.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6394

Note: See TracTickets for help on using tickets.