Ticket #5547 (closed: fixed)
Waterfall plot fills area under the curves with wrong colour
| Reported by: | Roman Tolchenov | Owned by: | John Hill |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.3 |
| Component: | MantidPlot | Keywords: | Student |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Nick Draper |
Description
When you select Enable Fill in "Fill Curves" dialog and "Fill with Color" shows white the area under each curve is filled with the same colour as the line. To select white first you need to select a different colour and after that switch to white.
Change History
comment:2 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.3 to Release 2.4
Moved to milestone 2.4
comment:3 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.4 to Release 2.5
Moved at the code freeze for release 2.4
comment:5 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.6 to Backlog
Moved to backlog at the code freeze for R2.6
comment:6 Changed 7 years ago by Nick Draper
- Status changed from new to assigned
Bulk move to assigned at the introduction of the triage step
comment:11 Changed 6 years ago by John Hill
- Status changed from assigned to inprogress
Refs #5547 separated dialog creation to own class
Changeset: 90f6c5aa9110978e1ab48a7d9f0d5e6694c91dac
comment:12 Changed 6 years ago by John Hill
Refs #5547 fixed warning
Changeset: ffba224a162cccda0f4084bff40d3e4e5d43d644
comment:13 Changed 6 years ago by John Hill
Refs #5547 changed styling
Changeset: 84a5fa821d93350a147a80244c75372faabd200d
comment:14 Changed 6 years ago by John Hill
- Status changed from inprogress to verify
- Resolution set to fixed
comment:15 Changed 6 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:16 Changed 6 years ago by Nick Draper
- Status changed from verifying to reopened
- Resolution fixed deleted
Functionally this tested ok, and would pass, in fact I think it is a really nice improvement.
In the code some of the variable names like gb1, gb2 and possibly hl1 are too hard to work out what they are.
This is particularly confusing in the line
if (gb1.checked && gb.checked)
as without searching around you have no idea what is happening
comment:17 Changed 6 years ago by John Hill
- Status changed from reopened to inprogress
Refs #5547 clarified some variable names
Changeset: 0b88fe2e4fed54ff8269958867d0bc49d0b66a2b
comment:18 Changed 6 years ago by John Hill
- Status changed from inprogress to verify
- Resolution set to fixed
comment:20 Changed 6 years ago by Nick Draper
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/5547_waterfall_fill_incorrect'
Full changeset: 4fab98a883b96bb5023435ce55688b7ecde434db
comment:21 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6393
Moved at the end of release 2.2