Change Phase angle range to (-pi:+pi) in Muon Oscillating Fit Functions

[Karl Palmen]

The muon oscillating fit functions presently put the phase angle parameter in the range 0 to 2pi. We have found out that the muon scientist prefer the range -pi to +pi.

This ticket is to change this range as described for all muon fitting functions that have a phase angle parameter.

[Karl Palmen]

Change needed in

Abragam.cpp

ExpDecayOsc.cpp

GausOsc.cpp

[Karl Palmen]

All three unit tests use are phase angle of 45 degrees and so do not need changing.

[Karl Palmen]

Changed phase angle range as required by re #5542

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b65765e8aead5b88637fb30c02606701ffe43052

[Karl Palmen]

Tidy up code re #5542

Changeset: 946522d00f7fbc76e441549749d04e4a01e30f60

[Karl Palmen]

Changed phase angle range as required by re #5542

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b65765e8aead5b88637fb30c02606701ffe43052

[Karl Palmen]

Tidy up code re #5542

Changeset: 946522d00f7fbc76e441549749d04e4a01e30f60

[Karl Palmen]

I suggest you execute CreateWorkspace with arguments such as

dataX = [-1,0,1,2,3,4,5,6,7,8,9,10,11]

dataY = [10,7,0,-7,-10,-7,0,7,10,7,0,-7]

dataE = [1,1,1,1,1,1,1,1,1,1,1,1]

Fit the function to it noting the phase angle parameter. Repeat with a constant added to the values of dataX to get both positive and negative phase angles. The phase angle parameter should be greater than minus pi, but no greater than plus pi.

[Anders Markvardsen]

Tried fitting parts of a EMU data set to all three above mentioned fitting functions varying the starting values and in all cases phase between -pi and pi

[Stuart Campbell]

This ticket has been transferred to github issue ​6389