Ticket #5549 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

New algorithm for focus part of SNSPowderReduction

Reported by: Vickie Lynch Owned by: Vickie Lynch
Priority: major Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

Make a focus algorithm containing what is in _focus function inside SNSPowderReduction.

Change History

comment:1 Changed 8 years ago by Vickie Lynch

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Vickie Lynch

Refs #5549 start of focus algorithm

Changeset: 7b76b1b89fcd658ad8f256bdf7ec4e493c9cc6df

comment:3 Changed 8 years ago by Vickie Lynch

comment:4 Changed 8 years ago by Vickie Lynch

Refs #5549 add masking

Changeset: 320b8181a11f42800aeba2f854e38675bf75692b

comment:5 Changed 8 years ago by Vickie Lynch

Refs #5549 filters, compressing, sorting

Changeset: b0406fcc736362fd23b80fb42fa59ff6bee18f58

comment:6 Changed 8 years ago by Vickie Lynch

Refs #5549 default binning

Changeset: d9827036c5de43cffd855d041d8f096c4243d679

comment:7 Changed 8 years ago by Vickie Lynch

Refs #5549 fix windows?

Changeset: af786d98928654a599bd4bb945914dcf22b429de

comment:8 Changed 8 years ago by Vickie Lynch

Refs #5549 fix windows?

Changeset: ca31bd673271b11a9f84da2c0d1ecefc6fe440c8

comment:9 Changed 8 years ago by Vickie Lynch

Refs #5549 move to WorkflowAlgorithms

Changeset: 41a4640ff5dc1709f52c27fbf647289c54a6fb81

comment:10 Changed 8 years ago by Vickie Lynch

Refs #5549 more options

Changeset: e699bfe7a7900faa6f94521251faa836e602ee88

comment:11 Changed 8 years ago by Vickie Lynch

Refs #5549 fix final rebin

Changeset: 4e51c2ca8c14d3663b4cd3020a4883bf338a0b0a

comment:12 Changed 8 years ago by Vickie Lynch

Refs #5549 fix tmin,tmax

Changeset: 1c49de2ed472418d84c7c1f0a8992f97b7e3e280

comment:13 Changed 8 years ago by Vickie Lynch

Refs #5549 fix crop and preserveEvents

Changeset: 6f2555c5698fa00769ab4ce38afcf68b20434115

comment:14 Changed 8 years ago by Vickie Lynch

Refs #5549 sort function

Changeset: 45f4bdb0760daa22fecc252265be4a2bdfa5a3f8

comment:15 Changed 8 years ago by Vickie Lynch

Refs #5549 start of focus algorithm

Changeset: 7b76b1b89fcd658ad8f256bdf7ec4e493c9cc6df

comment:16 Changed 8 years ago by Vickie Lynch

comment:17 Changed 8 years ago by Vickie Lynch

Refs #5549 add masking

Changeset: 320b8181a11f42800aeba2f854e38675bf75692b

comment:18 Changed 8 years ago by Vickie Lynch

Refs #5549 filters, compressing, sorting

Changeset: b0406fcc736362fd23b80fb42fa59ff6bee18f58

comment:19 Changed 8 years ago by Vickie Lynch

Refs #5549 default binning

Changeset: d9827036c5de43cffd855d041d8f096c4243d679

comment:20 Changed 8 years ago by Vickie Lynch

Refs #5549 fix windows?

Changeset: af786d98928654a599bd4bb945914dcf22b429de

comment:21 Changed 8 years ago by Vickie Lynch

Refs #5549 fix windows?

Changeset: ca31bd673271b11a9f84da2c0d1ecefc6fe440c8

comment:22 Changed 8 years ago by Vickie Lynch

Refs #5549 move to WorkflowAlgorithms

Changeset: 41a4640ff5dc1709f52c27fbf647289c54a6fb81

comment:23 Changed 8 years ago by Vickie Lynch

Refs #5549 SNSPowderReduction calls AlignAndFocus workflow

Changeset: 830074897649ccc680926b0aaeb1fa63475cf723

comment:24 Changed 8 years ago by Vickie Lynch

Refs #5549 don't reload cal file for chunks

Changeset: d0272fc147009ab962e9b306532532cc31aa3acb

comment:25 Changed 8 years ago by Vickie Lynch

  • Status changed from accepted to verify
  • Resolution set to fixed

Passes system tests for Powder Reduction.

comment:26 Changed 8 years ago by Vickie Lynch

Refs #5549 focus in place

Changeset: 0f89624a779b6b92972c63ad11912cadf80967b5

comment:27 Changed 8 years ago by Vickie Lynch

Refs #5549 focus before ConvertUnits

Changeset: e57a18dc5f56d7f321008d601a309a7ee224a68e

comment:28 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:29 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to closed

I've looked to see that the system tests are completing correctly and I've run the SNSPowderReduction algorithm by hand, and I don't see any problems.

comment:30 Changed 8 years ago by Vickie Lynch

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:31 Changed 8 years ago by Vickie Lynch

  • Status changed from reopened to accepted

comment:32 Changed 8 years ago by Vickie Lynch

Refs #5549 found bug doing mpi scaling tests

Changeset: c96956c1ca40c08a39fc25ac959407f707a12493

comment:33 Changed 8 years ago by Vickie Lynch

  • Status changed from accepted to verify
  • Resolution set to fixed

Works now with a large number of chunks or mpi tasks while binning in TOF. Some NOMAD workspaces had no events and CropWorkspaces does not work on workspaces with no events.

comment:34 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying

comment:35 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to closed

The fix looks simple enough and the normal things still work OK.

comment:36 Changed 8 years ago by Vickie Lynch

Refs #5549 found bug doing mpi scaling tests

Changeset: c96956c1ca40c08a39fc25ac959407f707a12493

comment:37 Changed 8 years ago by Vickie Lynch

Refs #5549 SNSPowderReduction calls AlignAndFocus workflow

Changeset: 830074897649ccc680926b0aaeb1fa63475cf723

comment:38 Changed 8 years ago by Vickie Lynch

Refs #5549 don't reload cal file for chunks

Changeset: d0272fc147009ab962e9b306532532cc31aa3acb

comment:39 Changed 8 years ago by Vickie Lynch

Refs #5549 focus in place

Changeset: 0f89624a779b6b92972c63ad11912cadf80967b5

comment:40 Changed 8 years ago by Vickie Lynch

Refs #5549 focus before ConvertUnits

Changeset: e57a18dc5f56d7f321008d601a309a7ee224a68e

comment:41 Changed 8 years ago by Vickie Lynch

Refs #5549 found bug doing mpi scaling tests

Changeset: c96956c1ca40c08a39fc25ac959407f707a12493

comment:42 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 6395

Note: See TracTickets for help on using tickets.