Ticket #5570 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

AddPeaks

Reported by: Nick Draper Owned by: Russell Taylor
Priority: critical Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

A new algorithm to add peaks workspaces together.

We need to avoid duplicating identical peaks, so a tolerance in Qx,y,z will be required. Expose this as a parameter so it can be adjusted.

Change History

comment:1 Changed 8 years ago by Russell Taylor

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Russell Taylor

Re #5570. First cut at an algorithm to combine peaks workspaces.

Follows exactly what's written in the ticket. Peaks in the second workspace that are within the given Q tolerance in all directions don't make it into the output. Note that it's quite possible for a given peak in the first workspace to be matched to multiple peaks in the second, if the tolerance is large enough/the peaks are close together.

Changeset: 9bc5337158861f9a9e585a78798b2690c08bad6b

comment:3 Changed 8 years ago by Russell Taylor

Re #5570. Clear compiler warnings.

Changeset: c7b4845b8271dbfb66370178cc87de73c55dedac

comment:4 Changed 8 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 8 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:6 Changed 8 years ago by Owen Arnold

  • Status changed from verifying to closed

This works as I expect it to. Also checked the unit tests, which appear to provide good coverage of this new feature. Also did a brief code check, which raised no warnings.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6416

Note: See TracTickets for help on using tickets.