Ticket #5571 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

SubtractPeaks

Reported by: Nick Draper Owned by: Russell Taylor
Priority: critical Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

Similar to AddPeaks, but to remove peaks which match within a tolerence.

Change History

comment:1 Changed 8 years ago by Russell Taylor

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Russell Taylor

Re #5571. First cut at algorithm to subtract matching peaks.

Processes the peaks in the rhs workspace, removing the first match it finds (in Q, within the given tolerance) from the peaks in the lhs workspace.

Changeset: 6ada67cf4f9200f292e56bc217a705e7c33d20df

comment:3 Changed 8 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 8 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:5 Changed 8 years ago by Owen Arnold

  • Status changed from verifying to closed

Does what I expect it to when running in MantidPlot and tweaking the Tolerance. Really good test coverage with this new algorithm.

As a minor point, the algorithm is documented on the wiki, but the WIKI section in the cpp file has not been updated. This will cause the existing documentation to get overwritten if wiki maker is re-run on this algorithm. #5570 Has the same problem.

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6417

Note: See TracTickets for help on using tickets.