Ticket #5572 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

FilterPeaks

Reported by: Nick Draper Owned by: Owen Arnold
Priority: critical Milestone: Release 2.6
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester:

Description (last modified by Owen Arnold) (diff)

Allow peaks workspaces to be filtered - to a new workspace. On the following:

  • H+K+L
  • H2+K2+L2
  • Intensity

Allow those values to be compared (<,>,=,<=,>=) to a user supplied value.

Another filtering option is Signal/Noise where peaks with integrated intensity < n sigma would be discarded (default n=3).

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Description modified (diff)

comment:2 Changed 8 years ago by Russell Taylor

  • Status changed from new to accepted

comment:3 Changed 8 years ago by Russell Taylor

Re #5572. Very quick first implementation of FilterPeaks.

Changeset: 25d01d44ed6e395e9e16c20c0f3d824770034bf1

comment:4 Changed 8 years ago by Russell Taylor

Re #5572. MSVC dislikes method name HKL for some reason.

Changeset: a833e327dd83822baae34d8906f09c0bd6291ba9

comment:5 Changed 8 years ago by Russell Taylor

Re #5572. Compiler warnings.

Changeset: a8c20243f6dd479f7d1e5122580b40409ff5606e

comment:6 Changed 8 years ago by Russell Taylor

Re #5572. Very quick first implementation of FilterPeaks.

Changeset: 25d01d44ed6e395e9e16c20c0f3d824770034bf1

comment:7 Changed 8 years ago by Russell Taylor

Re #5572. MSVC dislikes method name HKL for some reason.

Changeset: a833e327dd83822baae34d8906f09c0bd6291ba9

comment:8 Changed 8 years ago by Russell Taylor

Re #5572. Compiler warnings.

Changeset: a8c20243f6dd479f7d1e5122580b40409ff5606e

comment:9 Changed 8 years ago by Russell Taylor

Re #5572. Minor changes.

Changeset: 53b150c9711524753697916da4bb91ec06815911

comment:10 Changed 8 years ago by Russell Taylor

Re #5572. Don't register into algorithm factory for now.

This one isn't ready for the big time yet.

Changeset: d6500c24370d29ff21c2cbba90a2844f8e189df1

comment:11 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:12 Changed 8 years ago by Russell Taylor

Re #5572. Don't register into algorithm factory for now.

This one isn't ready for the big time yet.

Changeset: d6500c24370d29ff21c2cbba90a2844f8e189df1

comment:13 Changed 8 years ago by Russell Taylor

Revert "Re #5572. Don't register into algorithm factory for now."

This reverts commit d6500c24370d29ff21c2cbba90a2844f8e189df1.

Changeset: 666fd7e29870a43b40118e112b4b99fcd750ca7c

comment:14 Changed 8 years ago by Russell Taylor

Re #5572. Minor changes.

Changeset: 53b150c9711524753697916da4bb91ec06815911

comment:15 Changed 8 years ago by Russell Taylor

Re #5572. Don't register into algorithm factory for now.

This one isn't ready for the big time yet.

Changeset: d6500c24370d29ff21c2cbba90a2844f8e189df1

comment:16 Changed 8 years ago by Russell Taylor

Revert "Re #5572. Don't register into algorithm factory for now."

This reverts commit d6500c24370d29ff21c2cbba90a2844f8e189df1.

Changeset: 666fd7e29870a43b40118e112b4b99fcd750ca7c

comment:17 Changed 8 years ago by Russell Taylor

Re #5572. Don't register into algorithm factory for now.

This one isn't ready for the big time yet.

Changeset: 1268975523fbeeae1f013d54a7ffdde2c3fd97db

comment:18 Changed 8 years ago by Russell Taylor

  • Milestone changed from Release 2.3 to Release 2.4

comment:19 Changed 8 years ago by Russell Taylor

Re #5572. Don't register into algorithm factory for now.

This one isn't ready for the big time yet.

Changeset: 1268975523fbeeae1f013d54a7ffdde2c3fd97db

comment:20 Changed 8 years ago by Russell Taylor

  • Status changed from accepted to assigned

comment:21 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:22 Changed 7 years ago by Russell Taylor

  • Milestone changed from Release 2.5 to Release 2.6

Move the tickets I'm definitely not going to do this iteration so that I can better see the ones that I might.

comment:23 Changed 7 years ago by Russell Taylor

  • Owner changed from Russell Taylor to Owen Arnold

The current status is that a simple implementation is there, but the algorithm is not registered into the factory so does not show up.

comment:24 Changed 7 years ago by Owen Arnold

  • Description modified (diff)

It this does what it's supposed to, then I think it should just be a case of enabling the algorithm, and providing a proper set of unit tests for all the options available.

comment:25 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:26 Changed 7 years ago by Owen Arnold

refs #5572. Add Tests for algorithm.

Add performance tests. Also add functional tests for the various filtering options on this algorithm.

Changeset: 59eb25d5d2bb95f8d75e9caabf34a257db05d19a

comment:27 Changed 7 years ago by Owen Arnold

refs #5572. Add documentation for the algorithm.

Changeset: 846c5c42e138e50443e9079fdc25c3842117d7f3

comment:28 Changed 7 years ago by Owen Arnold

Pending a checkbuild step.

comment:29 Changed 7 years ago by Owen Arnold

refs #5572. Duplicate headers included.

Changeset: 9e514cf30008c18bc7a29f72ae23484e14b7f86c

comment:30 Changed 7 years ago by Owen Arnold

  • Status changed from new to verify
  • Resolution set to fixed

Tester: The unit tests should give good confidence that this algorithm is doing the right thing.

A good workspace to use as an input can be fetched as follows: 

LoadIsawPeaks(Filename='TOPAZ_3007.peaks', OutputWorkspace='peaks')

comment:31 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:32 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Diffraction

comment:33 Changed 7 years ago by Gesner Passos

  • Status changed from verify to closed

Merge remote-tracking branch 'origin/feature/5572_filter_peaks'

comment:34 Changed 7 years ago by Gesner Passos

I've tested the algorithm against some inputs and different arguments. All worked nicely.

comment:35 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6418

Note: See TracTickets for help on using tickets.